Fix translations for built-in extensions missing in remote mode #251252
+14
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using VS Code in remote mode with a non-English UI language, translations for built-in extensions (like Git source control) were missing and remained in English, while the rest of the UI was properly localized.
Root Cause
The issue had two main components:
Missing NLS keys in remote builds: The
nls.keys.json
file wasn't included in the remote server build, preventing proper NLS (National Language Support) resolution for built-in extensions.UI language not propagated to backend: When scanning built-in extensions on the remote server, the current UI language wasn't being passed from the client, so the server couldn't load the appropriate translations.
Changes
1. Include NLS keys in remote server build
'out-build/nls.keys.json'
toserverResourceIncludes
to ensure NLS keys are available in remote builds2. Fix NLS resolution logic
3. Propagate UI language through extension management chain
language
parameter togetInstalled
method signaturelanguage
constant and pass it through IPC callsgetInstalled
andscanExtensions
to accept and use the language parameterThe language now flows: Client → IPC → ExtensionManagementService → ExtensionsScanner → ExtensionsScannerService.scanAllExtensions → scanDefaultSystemExtensions(language)
Testing
All changes maintain backward compatibility with optional parameters and minimal modifications to existing interfaces.
Fixes #250579.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
electronjs.org
node-gyp
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.