Skip to content

[WIP][docs] Add "Edit in Mui Chat" button on demos #46480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jul 3, 2025

Preview: https://deploy-preview-46480--material-ui.netlify.app/material-ui/react-button/

This PR aims to connect docs with MUI Chat. It begins with an idea to have a button on each demo that opens MUI Chat to let users extend the demo with prompts.

However, I don't think it's the best approach to introduce MUI Chat because:

  • It takes time until users can see the result. Requires authentication to access MUI Chat.
  • Users could feel lost especially new to MUI Chat

Proposal

With the above issues, I think the connection from docs to MUI Chat should be on specific demo (probably the first demo) with predefine prompts that are common to that components.

For example

Button:

  • Github style customization
  • Stripe style theming
  • Asynchronous action with loading button
  • Button with skeleton loading

The first open should not require authentication, may be best to show the predefined result. If users want to extend the prompt, then they need to be authenticated.


@siriwatknp siriwatknp added the docs Improvements or additions to the documentation label Jul 3, 2025
@mui-bot
Copy link

mui-bot commented Jul 3, 2025

Netlify deploy preview

https://deploy-preview-46480--material-ui.netlify.app/

Bundle size report

Bundle Parsed Size Gzip Size
@mui/material 0B(0.00%) 0B(0.00%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 5c463a0

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 3, 2025

Linking the original one for context: mui/mui-x#17250 and clarity.

The strategy to deploy this is available in: https://www.notion.so/mui-org/store-Weekly-meeting-2025-06-16-214cbfe7b66080f7a10cd3c74d5a2aa5?source=copy_link#222cbfe7b660808a9866ca671dc45b39. We are eventually adding it to all the demos.

data-ga-event-category="mui-chat"
data-ga-event-label={demo.gaLabel}
data-ga-event-action="open-in-mui-chat"
{...getControlProps(10)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something strange is happing here, this button is not accessible with the keyboard like all the other controls on the toolbar.

@siriwatknp
Copy link
Member Author

Linking the original one for context: mui/mui-x#17250 and clarity.

The strategy to deploy this is available in: https://www.notion.so/mui-org/store-Weekly-meeting-2025-06-16-214cbfe7b66080f7a10cd3c74d5a2aa5?source=copy_link#222cbfe7b660808a9866ca671dc45b39. We are eventually adding it to all the demos.

I don't think the links you provided clarify my points in the PR description. The info in the Notion page is not a concrete plan, there are words like "What if it was".

We are eventually adding it to all the demos.

Agree but I don't think we have to do it since the beginning.

@siriwatknp siriwatknp requested a review from hasdfa July 4, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants