-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[WIP][docs] Add "Edit in Mui Chat" button on demos #46480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Netlify deploy previewhttps://deploy-preview-46480--material-ui.netlify.app/ Bundle size report
|
Linking the original one for context: mui/mui-x#17250 and clarity. The strategy to deploy this is available in: https://www.notion.so/mui-org/store-Weekly-meeting-2025-06-16-214cbfe7b66080f7a10cd3c74d5a2aa5?source=copy_link#222cbfe7b660808a9866ca671dc45b39. We are eventually adding it to all the demos. |
data-ga-event-category="mui-chat" | ||
data-ga-event-label={demo.gaLabel} | ||
data-ga-event-action="open-in-mui-chat" | ||
{...getControlProps(10)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something strange is happing here, this button is not accessible with the keyboard like all the other controls on the toolbar.
I don't think the links you provided clarify my points in the PR description. The info in the Notion page is not a concrete plan, there are words like "What if it was".
Agree but I don't think we have to do it since the beginning. |
Preview: https://deploy-preview-46480--material-ui.netlify.app/material-ui/react-button/
This PR aims to connect docs with MUI Chat. It begins with an idea to have a button on each demo that opens MUI Chat to let users extend the demo with prompts.
However, I don't think it's the best approach to introduce MUI Chat because:
Proposal
With the above issues, I think the connection from docs to MUI Chat should be on specific demo (probably the first demo) with predefine prompts that are common to that components.
For example
Button:
Github style customization
Stripe style theming
Asynchronous action with loading button
Button with skeleton loading
The first open should not require authentication, may be best to show the predefined result. If users want to extend the prompt, then they need to be authenticated.