Skip to content

frontend: Add template for Qt's invokeMethod #12259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cg2121
Copy link
Contributor

@cg2121 cg2121 commented Jun 7, 2025

Description

This adds a template for when OBS signals are called, so we don't have to call invokeMethod each time. This only works if the invokeMethod doesn't have calldata_t used with it.

Motivation and Context

Wanted to find a way so we didn't have to write a invokeMethod function for each OBS signal.

This is only used in MediaControls at this time. If this is accepted, I'll PR for other places later.

How Has This Been Tested?

Used media controls to make sure everything works as expected.

Types of changes

  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@cg2121 cg2121 added the Code Cleanup Non-breaking change which makes code smaller or more readable label Jun 7, 2025
This adds a template for when OBS signals are called, so we don't
have to call invokeMethod each time. This only works if the invokeMethod
doesn't have calldata_t used with it.
@cg2121 cg2121 force-pushed the invokeMethod-template branch from 949a839 to 4cea598 Compare June 7, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup Non-breaking change which makes code smaller or more readable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant