enabled filtering of /subscriptions by external customer ID

[mshra]

solves #5828

[vercel]

@mshra is attempting to deploy a commit to the polar-sh Team on Vercel.

A member of the Team first needs to authorize it.

[frankie567]

Thank you @mshra, that's exactly it. May I ask you to run the linter?

cd server/
uv run task lint && uv run task lint_types

[frankie567]

Another thing @mshra:

Can we call the parameter external_customer_id, to be consistent with other API (related to #5787)?

[mshra]

Thank you @mshra, that's exactly it. May I ask you to run the linter?

cd server/
uv run task lint && uv run task lint_types

apparently, when I ran uv run task lint_types
I get this output

pyproject.toml:1: error: Error importing plugin "pydantic.mypy": No module named 'pydantic'  [misc]
Found 1 error in 1 file (errors prevented further checking)

which is weird because I do have pydantic as my dependencies when I freeze

> uv pip freeze | grep "pydantic"
pydantic==2.10.6
pydantic-core==2.27.2
pydantic-extra-types==2.10.5
pydantic-settings==2.9.1

am I missing something?

[mshra]

Another thing @mshra:

Can we call the parameter external_customer_id, to be consistent with other API (related to #5787)?

Sure thing @frankie567 , will look into this 👍🏽

[frankie567]

Thank you @mshra, that's exactly it. May I ask you to run the linter?

cd server/
uv run task lint && uv run task lint_types

apparently, when I ran uv run task lint_types I get this output

pyproject.toml:1: error: Error importing plugin "pydantic.mypy": No module named 'pydantic'  [misc]
Found 1 error in 1 file (errors prevented further checking)

which is weird because I do have pydantic as my dependencies when I freeze

> uv pip freeze | grep "pydantic"
pydantic==2.10.6
pydantic-core==2.27.2
pydantic-extra-types==2.10.5
pydantic-settings==2.9.1

am I missing something?

Weird indeed. Did you run uv sync before running the command? It should install all the required dependencies.

[mshra]

Apparently, my uv version was out of date. My bad and thank you for assistance @frankie567

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
polar	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 19, 2025 2:42pm
polar-sandbox	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 19, 2025 2:42pm

[malthejorgensen]

@mshra We can merge this if you rename customer_external_id to external_customer_id

(from #5937 (comment))

[mshra]

Hi @frankie567 @malthejorgensen , I have a question regarding naming convention for CustomerExternalID, should that be changed to ExternalCustomerID as well (to match customer_id and CustomerID convention) ?

As the CustomerExternalID also has a dependency in server/polar/customer/endpoints.py

[frankie567]

@mshra Good point, and I would say, ideally, yes :) If you can change that too, would be awesome 🙏

[mshra]

noted @frankie567 and pushed the latest changes

[frankie567]

Perfect, thanks 🙏