Consider module in GetEmitScriptTarget (microsoft#733)

Author: Andarist

internal/core/compileroptions.go

@@ -142,7 +142,14 @@ func (options *CompilerOptions) GetEmitScriptTarget() ScriptTarget {
 	if options.Target != ScriptTargetNone {
 		return options.Target
 	}
-	return ScriptTargetES5
+	switch options.GetEmitModuleKind() {
+	case ModuleKindNode16:
+		return ScriptTargetES2022
+	case ModuleKindNodeNext:
+		return ScriptTargetESNext
+	default:
+		return ScriptTargetES5
+	}
 }
 
 func (options *CompilerOptions) GetEmitModuleKind() ModuleKind {

testdata/baselines/reference/submodule/compiler/dtsEmitTripleSlashAvoidUnnecessaryResolutionMode.symbols

@@ -7,7 +7,7 @@ export async function drainStream(stream: NodeJS.ReadableStream): Promise<void>
 >stream : Symbol(stream, Decl(app.mts, 1, 34))
 >NodeJS : Symbol(NodeJS, Decl(globals.d.ts, 0, 0))
 >ReadableStream : Symbol(ReadableStream, Decl(globals.d.ts, 0, 26))
->Promise : Symbol(Promise, Decl(lib.es5.d.ts, --, --))
+>Promise : Symbol(Promise, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.iterable.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --), Decl(lib.es2018.promise.d.ts, --, --))
 }
 
 === /node_modules/@types/node/globals.d.ts ===

testdata/baselines/reference/submodule/compiler/dtsEmitTripleSlashAvoidUnnecessaryResolutionMode.symbols.diff

@@ -5,9 +5,7 @@
  >stream : Symbol(stream, Decl(app.mts, 1, 34))
  >NodeJS : Symbol(NodeJS, Decl(globals.d.ts, 0, 0))
 ->ReadableStream : Symbol(NodeJS.ReadableStream, Decl(globals.d.ts, 0, 26))
-->Promise : Symbol(Promise, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.iterable.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --), Decl(lib.es2018.promise.d.ts, --, --))
 +>ReadableStream : Symbol(ReadableStream, Decl(globals.d.ts, 0, 26))
-+>Promise : Symbol(Promise, Decl(lib.es5.d.ts, --, --))
+ >Promise : Symbol(Promise, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.iterable.d.ts, --, --), Decl(lib.es2015.promise.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --), Decl(lib.es2018.promise.d.ts, --, --))
  }
 
- === /node_modules/@types/node/globals.d.ts ===

testdata/baselines/reference/submodule/compiler/parseAssertEntriesError.errors.txt

@@ -1,4 +1,3 @@
-error TS2468: Cannot find global value 'Promise'.
 /index.ts(2,7): error TS1340: Module 'pkg' does not refer to a type, but is used as a type here. Did you mean 'typeof import('pkg')'?
 /index.ts(2,32): error TS1478: Identifier or string literal expected.
 /index.ts(2,32): error TS2695: Left side of comma operator is unused and has no side effects.
@@ -8,7 +7,6 @@ error TS2468: Cannot find global value 'Promise'.
 /index.ts(2,69): error TS1128: Declaration or statement expected.
 /index.ts(2,70): error TS1128: Declaration or statement expected.
 /index.ts(2,71): error TS2304: Cannot find name 'RequireInterface'.
-/index.ts(3,7): error TS2712: A dynamic import call in ES5 requires the 'Promise' constructor.  Make sure you have a declaration for the 'Promise' constructor or include 'ES2015' in your '--lib' option.
 /index.ts(3,36): error TS1005: ':' expected.
 /index.ts(3,70): error TS2339: Property 'ImportInterface' does not exist on type 'Promise<{ default: typeof import("/node_modules/pkg/require"); }>'.
 /index.ts(5,34): error TS1340: Module 'pkg' does not refer to a type, but is used as a type here. Did you mean 'typeof import('pkg')'?
@@ -35,8 +33,7 @@ error TS2468: Cannot find global value 'Promise'.
 /index.ts(6,112): error TS1128: Declaration or statement expected.
 
 
-!!! error TS2468: Cannot find global value 'Promise'.
-==== /index.ts (34 errors) ====
+==== /index.ts (33 errors) ====
     export type LocalInterface =
         & import("pkg", { assert: {1234, "resolution-mode": "require"} }).RequireInterface
           ~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -58,8 +55,6 @@ error TS2468: Cannot find global value 'Promise'.
                                                                           ~~~~~~~~~~~~~~~~
 !!! error TS2304: Cannot find name 'RequireInterface'.
         & import("pkg", { assert: {1234, "resolution-mode": "import"} }).ImportInterface;
-          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-!!! error TS2712: A dynamic import call in ES5 requires the 'Promise' constructor.  Make sure you have a declaration for the 'Promise' constructor or include 'ES2015' in your '--lib' option.
                                        ~
 !!! error TS1005: ':' expected.
                                                                          ~~~~~~~~~~~~~~~

testdata/baselines/reference/submodule/compiler/parseAssertEntriesError.errors.txt.diff

@@ -1,37 +1,15 @@
 --- old.parseAssertEntriesError.errors.txt
 +++ new.parseAssertEntriesError.errors.txt
-@@= skipped -0, +0 lines =@@
-+error TS2468: Cannot find global value 'Promise'.
- /index.ts(2,7): error TS1340: Module 'pkg' does not refer to a type, but is used as a type here. Did you mean 'typeof import('pkg')'?
- /index.ts(2,32): error TS1478: Identifier or string literal expected.
- /index.ts(2,32): error TS2695: Left side of comma operator is unused and has no side effects.
-@@= skipped -6, +7 lines =@@
- /index.ts(2,69): error TS1128: Declaration or statement expected.
+@@= skipped -7, +7 lines =@@
  /index.ts(2,70): error TS1128: Declaration or statement expected.
  /index.ts(2,71): error TS2304: Cannot find name 'RequireInterface'.
-+/index.ts(3,7): error TS2712: A dynamic import call in ES5 requires the 'Promise' constructor.  Make sure you have a declaration for the 'Promise' constructor or include 'ES2015' in your '--lib' option.
  /index.ts(3,36): error TS1005: ':' expected.
 -/index.ts(3,70): error TS2339: Property 'ImportInterface' does not exist on type 'Promise<{ default: typeof import("/node_modules/pkg/import"); }>'.
 +/index.ts(3,70): error TS2339: Property 'ImportInterface' does not exist on type 'Promise<{ default: typeof import("/node_modules/pkg/require"); }>'.
  /index.ts(5,34): error TS1340: Module 'pkg' does not refer to a type, but is used as a type here. Did you mean 'typeof import('pkg')'?
  /index.ts(5,59): error TS1478: Identifier or string literal expected.
  /index.ts(5,59): error TS2695: Left side of comma operator is unused and has no side effects.
-@@= skipped -26, +27 lines =@@
- /index.ts(6,112): error TS1128: Declaration or statement expected.
- 
- 
--==== /index.ts (33 errors) ====
-+!!! error TS2468: Cannot find global value 'Promise'.
-+==== /index.ts (34 errors) ====
-     export type LocalInterface =
-         & import("pkg", { assert: {1234, "resolution-mode": "require"} }).RequireInterface
-           ~~~~~~~~~~~~~~~~~~~~~~~~~
-@@= skipped -22, +23 lines =@@
-                                                                           ~~~~~~~~~~~~~~~~
- !!! error TS2304: Cannot find name 'RequireInterface'.
-         & import("pkg", { assert: {1234, "resolution-mode": "import"} }).ImportInterface;
-+          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-+!!! error TS2712: A dynamic import call in ES5 requires the 'Promise' constructor.  Make sure you have a declaration for the 'Promise' constructor or include 'ES2015' in your '--lib' option.
+@@= skipped -50, +50 lines =@@
                                         ~
  !!! error TS1005: ':' expected.
                                                                           ~~~~~~~~~~~~~~~

testdata/baselines/reference/submodule/compiler/parseImportAttributesError.errors.txt

@@ -1,4 +1,3 @@
-error TS2468: Cannot find global value 'Promise'.
 /index.ts(2,7): error TS1340: Module 'pkg' does not refer to a type, but is used as a type here. Did you mean 'typeof import('pkg')'?
 /index.ts(2,30): error TS1478: Identifier or string literal expected.
 /index.ts(2,30): error TS2695: Left side of comma operator is unused and has no side effects.
@@ -8,7 +7,6 @@ error TS2468: Cannot find global value 'Promise'.
 /index.ts(2,67): error TS1128: Declaration or statement expected.
 /index.ts(2,68): error TS1128: Declaration or statement expected.
 /index.ts(2,69): error TS2304: Cannot find name 'RequireInterface'.
-/index.ts(3,7): error TS2712: A dynamic import call in ES5 requires the 'Promise' constructor.  Make sure you have a declaration for the 'Promise' constructor or include 'ES2015' in your '--lib' option.
 /index.ts(3,34): error TS1005: ':' expected.
 /index.ts(3,68): error TS2339: Property 'ImportInterface' does not exist on type 'Promise<{ default: typeof import("/node_modules/pkg/require"); }>'.
 /index.ts(5,34): error TS1340: Module 'pkg' does not refer to a type, but is used as a type here. Did you mean 'typeof import('pkg')'?
@@ -35,8 +33,7 @@ error TS2468: Cannot find global value 'Promise'.
 /index.ts(6,110): error TS1128: Declaration or statement expected.
 
 
-!!! error TS2468: Cannot find global value 'Promise'.
-==== /index.ts (34 errors) ====
+==== /index.ts (33 errors) ====
     export type LocalInterface =
         & import("pkg", { with: {1234, "resolution-mode": "require"} }).RequireInterface
           ~~~~~~~~~~~~~~~~~~~~~~~
@@ -58,8 +55,6 @@ error TS2468: Cannot find global value 'Promise'.
                                                                         ~~~~~~~~~~~~~~~~
 !!! error TS2304: Cannot find name 'RequireInterface'.
         & import("pkg", { with: {1234, "resolution-mode": "import"} }).ImportInterface;
-          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-!!! error TS2712: A dynamic import call in ES5 requires the 'Promise' constructor.  Make sure you have a declaration for the 'Promise' constructor or include 'ES2015' in your '--lib' option.
                                      ~
 !!! error TS1005: ':' expected.
                                                                        ~~~~~~~~~~~~~~~

testdata/baselines/reference/submodule/compiler/parseImportAttributesError.errors.txt.diff

@@ -1,37 +1,15 @@
 --- old.parseImportAttributesError.errors.txt
 +++ new.parseImportAttributesError.errors.txt
-@@= skipped -0, +0 lines =@@
-+error TS2468: Cannot find global value 'Promise'.
- /index.ts(2,7): error TS1340: Module 'pkg' does not refer to a type, but is used as a type here. Did you mean 'typeof import('pkg')'?
- /index.ts(2,30): error TS1478: Identifier or string literal expected.
- /index.ts(2,30): error TS2695: Left side of comma operator is unused and has no side effects.
-@@= skipped -6, +7 lines =@@
- /index.ts(2,67): error TS1128: Declaration or statement expected.
+@@= skipped -7, +7 lines =@@
  /index.ts(2,68): error TS1128: Declaration or statement expected.
  /index.ts(2,69): error TS2304: Cannot find name 'RequireInterface'.
-+/index.ts(3,7): error TS2712: A dynamic import call in ES5 requires the 'Promise' constructor.  Make sure you have a declaration for the 'Promise' constructor or include 'ES2015' in your '--lib' option.
  /index.ts(3,34): error TS1005: ':' expected.
 -/index.ts(3,68): error TS2339: Property 'ImportInterface' does not exist on type 'Promise<{ default: typeof import("/node_modules/pkg/import"); }>'.
 +/index.ts(3,68): error TS2339: Property 'ImportInterface' does not exist on type 'Promise<{ default: typeof import("/node_modules/pkg/require"); }>'.
  /index.ts(5,34): error TS1340: Module 'pkg' does not refer to a type, but is used as a type here. Did you mean 'typeof import('pkg')'?
  /index.ts(5,57): error TS1478: Identifier or string literal expected.
  /index.ts(5,57): error TS2695: Left side of comma operator is unused and has no side effects.
-@@= skipped -26, +27 lines =@@
- /index.ts(6,110): error TS1128: Declaration or statement expected.
- 
- 
--==== /index.ts (33 errors) ====
-+!!! error TS2468: Cannot find global value 'Promise'.
-+==== /index.ts (34 errors) ====
-     export type LocalInterface =
-         & import("pkg", { with: {1234, "resolution-mode": "require"} }).RequireInterface
-           ~~~~~~~~~~~~~~~~~~~~~~~
-@@= skipped -22, +23 lines =@@
-                                                                         ~~~~~~~~~~~~~~~~
- !!! error TS2304: Cannot find name 'RequireInterface'.
-         & import("pkg", { with: {1234, "resolution-mode": "import"} }).ImportInterface;
-+          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-+!!! error TS2712: A dynamic import call in ES5 requires the 'Promise' constructor.  Make sure you have a declaration for the 'Promise' constructor or include 'ES2015' in your '--lib' option.
+@@= skipped -50, +50 lines =@@
                                       ~
  !!! error TS1005: ':' expected.
                                                                         ~~~~~~~~~~~~~~~

testdata/baselines/reference/submodule/conformance/moduleResolutionWithoutExtension5.errors.txt

@@ -1,13 +1,8 @@
-error TS2468: Cannot find global value 'Promise'.
-/src/buzz.mts(2,1): error TS2712: A dynamic import call in ES5 requires the 'Promise' constructor.  Make sure you have a declaration for the 'Promise' constructor or include 'ES2015' in your '--lib' option.
 /src/buzz.mts(2,8): error TS2307: Cannot find module './foo' or its corresponding type declarations.
 
 
-!!! error TS2468: Cannot find global value 'Promise'.
-==== /src/buzz.mts (2 errors) ====
+==== /src/buzz.mts (1 errors) ====
     // Extensionless relative path dynamic import in an ES module
     import("./foo").then(x => x); // should error, ask for extension
-    ~~~~~~~~~~~~~~~
-!!! error TS2712: A dynamic import call in ES5 requires the 'Promise' constructor.  Make sure you have a declaration for the 'Promise' constructor or include 'ES2015' in your '--lib' option.
            ~~~~~~~
 !!! error TS2307: Cannot find module './foo' or its corresponding type declarations.

testdata/baselines/reference/submodule/conformance/moduleResolutionWithoutExtension5.errors.txt.diff

@@ -2,18 +2,12 @@
 +++ new.moduleResolutionWithoutExtension5.errors.txt
 @@= skipped -0, +0 lines =@@
 -/src/buzz.mts(2,8): error TS2834: Relative import paths need explicit file extensions in ECMAScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.
-+error TS2468: Cannot find global value 'Promise'.
-+/src/buzz.mts(2,1): error TS2712: A dynamic import call in ES5 requires the 'Promise' constructor.  Make sure you have a declaration for the 'Promise' constructor or include 'ES2015' in your '--lib' option.
 +/src/buzz.mts(2,8): error TS2307: Cannot find module './foo' or its corresponding type declarations.
 
 
--==== /src/buzz.mts (1 errors) ====
-+!!! error TS2468: Cannot find global value 'Promise'.
-+==== /src/buzz.mts (2 errors) ====
+ ==== /src/buzz.mts (1 errors) ====
      // Extensionless relative path dynamic import in an ES module
      import("./foo").then(x => x); // should error, ask for extension
-+    ~~~~~~~~~~~~~~~
-+!!! error TS2712: A dynamic import call in ES5 requires the 'Promise' constructor.  Make sure you have a declaration for the 'Promise' constructor or include 'ES2015' in your '--lib' option.
             ~~~~~~~
 -!!! error TS2834: Relative import paths need explicit file extensions in ECMAScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.
 +!!! error TS2307: Cannot find module './foo' or its corresponding type declarations.

testdata/baselines/reference/submodule/conformance/moduleResolutionWithoutExtension8.errors.txt

@@ -1,13 +1,8 @@
-error TS2468: Cannot find global value 'Promise'.
-/src/bar.cts(2,1): error TS2712: A dynamic import call in ES5 requires the 'Promise' constructor.  Make sure you have a declaration for the 'Promise' constructor or include 'ES2015' in your '--lib' option.
 /src/bar.cts(2,8): error TS2307: Cannot find module './foo' or its corresponding type declarations.
 
 
-!!! error TS2468: Cannot find global value 'Promise'.
-==== /src/bar.cts (2 errors) ====
+==== /src/bar.cts (1 errors) ====
     // Extensionless relative path dynamic import in a cjs module
     import("./foo").then(x => x); // should error, ask for extension
-    ~~~~~~~~~~~~~~~
-!!! error TS2712: A dynamic import call in ES5 requires the 'Promise' constructor.  Make sure you have a declaration for the 'Promise' constructor or include 'ES2015' in your '--lib' option.
            ~~~~~~~
 !!! error TS2307: Cannot find module './foo' or its corresponding type declarations.

testdata/baselines/reference/submodule/conformance/moduleResolutionWithoutExtension8.errors.txt.diff

@@ -2,18 +2,12 @@
 +++ new.moduleResolutionWithoutExtension8.errors.txt
 @@= skipped -0, +0 lines =@@
 -/src/bar.cts(2,8): error TS2834: Relative import paths need explicit file extensions in ECMAScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.
-+error TS2468: Cannot find global value 'Promise'.
-+/src/bar.cts(2,1): error TS2712: A dynamic import call in ES5 requires the 'Promise' constructor.  Make sure you have a declaration for the 'Promise' constructor or include 'ES2015' in your '--lib' option.
 +/src/bar.cts(2,8): error TS2307: Cannot find module './foo' or its corresponding type declarations.
 
 
--==== /src/bar.cts (1 errors) ====
-+!!! error TS2468: Cannot find global value 'Promise'.
-+==== /src/bar.cts (2 errors) ====
+ ==== /src/bar.cts (1 errors) ====
      // Extensionless relative path dynamic import in a cjs module
      import("./foo").then(x => x); // should error, ask for extension
-+    ~~~~~~~~~~~~~~~
-+!!! error TS2712: A dynamic import call in ES5 requires the 'Promise' constructor.  Make sure you have a declaration for the 'Promise' constructor or include 'ES2015' in your '--lib' option.
             ~~~~~~~
 -!!! error TS2834: Relative import paths need explicit file extensions in ECMAScript imports when '--moduleResolution' is 'node16' or 'nodenext'. Consider adding an extension to the import path.
 +!!! error TS2307: Cannot find module './foo' or its corresponding type declarations.