Avoid race condition requesting telemetry permissions

robertbrignull · robertbrignull · commit aa950eed6af6 · 2023-01-09T16:54:32.000Z
diff --git a/extensions/ql-vscode/src/telemetry.ts b/extensions/ql-vscode/src/telemetry.ts
@@ -95,10 +95,8 @@ export class TelemetryListener extends ConfigListener {
       CANARY_FEATURES.getValue() &&
       !ENABLE_TELEMETRY.getValue()
     ) {
-      await Promise.all([
-        this.setTelemetryRequested(false),
-        this.requestTelemetryPermission(),
-      ]);
+      await this.setTelemetryRequested(false);
+      await this.requestTelemetryPermission();
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -95,10 +95,8 @@ export class TelemetryListener extends ConfigListener {`
`95`	`95`	`CANARY_FEATURES.getValue() &&`
`96`	`96`	`!ENABLE_TELEMETRY.getValue()`
`97`	`97`	`) {`
`98`		`- await Promise.all([`
`99`		`- this.setTelemetryRequested(false),`
`100`		`- this.requestTelemetryPermission(),`
`101`		`- ]);`
	`98`	`+ await this.setTelemetryRequested(false);`
	`99`	`+ await this.requestTelemetryPermission();`
`102`	`100`	`}`
`103`	`101`	`}`
`104`	`102`