-
Notifications
You must be signed in to change notification settings - Fork 199
Dev #849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
alashchev17
wants to merge
133
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Dev #849
+11,238
−21,898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ependency, and simplify data structures
- Update `current_model` usages to incorporate Option type for better error handling. - Modify `ft_toolset` field to utilize Option type, reflecting potential absence of toolset data. - Enhance safety by using `.ok_or` method to provide meaningful error messages when current_model is not set. - Simplify certain sections by eliminating unnecessary variable initialization and comments. - Optimize the connection initialization by directly passing required parameters.
Eliminate the unused `resolve_chat_model` function from `caps.rs` and remove all references to the `tokenizer` in multiple files, simplifying function signatures and improving maintainability.
…rity and error handling improvements
Cloud interaction fixes
Replace the regex crate with fancy-regex to handle complex regex patterns more effectively. Update relevant imports and add unwrap_or(false) to is_match calls to safely handle regex errors. Modify Cargo.toml to include the fancy-regex dependency.
Debugging fixes
thread id fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.