Wallet v2 #2169
Wallet v2 #2169
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 16991000 | Triggered | Generic High Entropy Secret | c2c2f3a | docker/db/wallet-seed.sql | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
ekzyis
force-pushed
the
wallet-v2
branch
16 times, most recently
from
8ab0a08 to
afcc412
Compare
ekzyis
force-pushed
the
wallet-v2
branch
5 times, most recently
from
d9af095 to
e94cfe7
Compare
ekzyis
force-pushed
the
wallet-v2
branch
6 times, most recently
from
412f2c6 to
690b10b
Compare
The old schema can contain '' instead of NULL in the columns of wallets for receiving.
The loading state would go from false -> true -> false because it's false when the lazy query wasn't called yet.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: Invalid URL Handling and Inconsistent Parsing
The code accesses params.slug[0] without validating if params.slug exists or has elements, which can cause a TypeError for malformed URLs. Additionally, the parseInt(walletName) check is inconsistent with Number(walletName) used for the id prop. This allows non-fully-numeric strings (e.g., "123abc") to pass the parseInt check, resulting in id={NaN} being passed to WalletFormsComponent and causing unexpected behavior.
pages/wallets/[...slug].js#L9-L14
Was this report helpful? Give feedback by reacting with 👍 or 👎
|
Feel free to merge updates, but rebasing or forced pushes will make me grumpy. :D |
Description
close #1495 fix #2234
DX for supporting a new wallet: 926c706
TODOs / Overview of Changes
Vaulttable no longer contains foreign keys to wallets or usersWalletTemplateWalletWalletProtocolWalletSendNWC,WalletRecvNWC, ...)WalletTemplatetableadd placeholder wallets like Phoenix?master)(Use test payments with HODL invoices for wallet validation #1287)include wizard / multi-step formsprobably not in this PRCryptoKeyshow status of wallet network tests on attach in dedicated UI instead of relying on wallet logsdon't show "logs", show wallet events like a walletthis means that there won't be multiple log messages for the same payment. we will just show the current status of a payment, just like a wallet would do.WALLETSvsWALLETquery)WALLETon save or detachWALLETSif wallets changedCUSTOMwallet intoNWCandLN_ADDRwalletcan key hash and wallet encryption get out of sync?Test instructions
test_wallet_v2(id 21001)sndev login test_wallet_v2Screenshots
we now show wallets instead of protocols:
each wallet can now support multiple protocols for send or receive:
Checklist
Are your changes backwards compatible? Please answer below:
no
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
8For frontend changes: Tested on mobile, light and dark mode? Please answer below:
yes
Did you introduce any new environment variables? If so, call them out explicitly here:
no