Fix(npub): Do not parse npubs in links

[brymut]

Description

Add check to prevent parsing of npubs in links.

closes #2252

Screenshots

Before fix

After fix

Additional Context

Was anything unclear during your work on this PR? Anything we should definitely take a closer look at?

Checklist

Are your changes backward compatible? Please answer below:
Y
For example, a change is not backward compatible if you removed a GraphQL field or dropped a database column.

On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
10

For frontend changes: Tested on mobile, light and dark mode? Please answer below:

Did you introduce any new environment variables? If so, call them out explicitly here:
N

[ekzyis]

This wasn't specified in the ticket because, at the time, I wasn't aware of it, but if there's only a link, it will still parse the npub in the link to show the nostr embed.

I consider this part of the issue.

[brymut]

if there's only a link, it will still parse the npub in the link to show the nostr embed.

Ahh right, missed that too. Think I got a fix for that too.

[ekzyis]

This removed all nostr embeds except for link posts.

This should be parsed as a nostr embed:

https://njump.me/npub1nsyte9neefm3jle7dg5gw6mhchxyk75a6f5dng70l4l3a2mx0nashqv2jk

This should be parsed as a link to njump:

npub1nsyte9neefm3jle7dg5gw6mhchxyk75a6f5dng70l4l3a2mx0nashqv2jk

This should stay a raw link:

https://npub1nsyte9neefm3jle7dg5gw6mhchxyk75a6f5dng70l4l3a2mx0nashqv2jk.nsite.lol

[brymut]

😅 This has got quite complex/confusing for me, let me have another look

[brymut]

This should be parsed as a nostr embed:

https://njump.me/npub1nsyte9neefm3jle7dg5gw6mhchxyk75a6f5dng70l4l3a2mx0nashqv2jk

This should be parsed as a link to njump:

npub1nsyte9neefm3jle7dg5gw6mhchxyk75a6f5dng70l4l3a2mx0nashqv2jk

This should stay a raw link:

https://npub1nsyte9neefm3jle7dg5gw6mhchxyk75a6f5dng70l4l3a2mx0nashqv2jk.nsite.lol

Ok, just tested using this link & previously discussed points. I think this solution should work.

[cursor]

Bug: Nostr Link Embedding Logic Fails

The updated link processing logic introduces two regressions for Nostr links:

1. njump.me Nostr links are unconditionally converted to embeds, disregarding the textOnly and !hasTextSibling constraints. This results in unwanted embeds for links with surrounding text or custom link text.
2. Nostr links from other domains are explicitly prevented from becoming embeds, causing them to incorrectly render as autolinks even when they meet the textOnly and !hasTextSibling criteria for embed conversion.

lib/rehype-sn.js#L94-L100

stacker.news/lib/rehype-sn.js

Lines 94 to 100 in f6cff35

	if (embed?.provider === 'nostr' && host === 'njump.me') {
	node.tagName = 'embed'
	node.properties = { ...embed, src: href }
	return
	}
	if (embed && embed.provider !== 'nostr' && textOnly && !hasTextSibling) {

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎

[brymut]

Bugs as described by cursor are not described in spec. Either incorrect UX behaviour or undiscussed. I can confirm that everything discussed by human review on this PR has been addressed.

edit: not even sure I'll qualify for the rewards based on the number of reviews introduced by cursor and spec changes. 🥲