spin egress container for each mcp server #457

New issue

Jump to bottom

Merged

yrobla merged 7 commits into main from issue-124

Jun 13, 2025

Contributor

yrobla commented May 23, 2025

Closes: #124

yrobla marked this pull request as draft

May 23, 2025 09:45

yrobla force-pushed the issue-124 branch from 1dc6952 to 36379a5 Compare

May 23, 2025 09:46

JAORMX reviewed

View reviewed changes

cmd/thv/app/rm.go Outdated Show resolved Hide resolved

cmd/thv/app/rm.go Outdated Show resolved Hide resolved

JAORMX reviewed

View reviewed changes

pkg/transport/stdio.go Outdated Show resolved Hide resolved

Collaborator

JAORMX commented May 24, 2025

Yeah, let's keep the changes constrained to the Docker driver. Adding container and network details on the command and on the transport leak implementation details which are not applicable to every runtime. e.g. this doesn't apply to the k8s driver.

yrobla force-pushed the issue-124 branch 2 times, most recently from 16e9d02 to c44c509 Compare

May 26, 2025 09:42

yrobla marked this pull request as ready for review

May 26, 2025 11:16

yrobla changed the title ~~wip: spin egress container for each mcp server~~ spin egress container for each mcp server

JAORMX previously requested changes

View reviewed changes

pkg/permissions/profile.go Outdated Show resolved Hide resolved

pkg/container/docker/client.go Outdated Show resolved Hide resolved

pkg/runner/runner.go Outdated Show resolved Hide resolved

pkg/runner/runner.go Outdated Show resolved Hide resolved

pkg/container/docker/client.go Outdated Show resolved Hide resolved

pkg/container/docker/client.go Outdated Show resolved Hide resolved

dmjb reviewed

View reviewed changes

pkg/lifecycle/manager.go Outdated Show resolved Hide resolved

dmjb reviewed

View reviewed changes

cmd/thv/app/stop.go Outdated Show resolved Hide resolved

dmjb reviewed

View reviewed changes

cmd/thv/app/run.go Outdated Show resolved Hide resolved

dmjb reviewed

View reviewed changes

pkg/runner/config.go Outdated Show resolved Hide resolved

dmjb reviewed

View reviewed changes

pkg/lifecycle/manager.go Outdated Show resolved Hide resolved

yrobla force-pushed the issue-124 branch 2 times, most recently from f17e21f to 1e20612 Compare

June 2, 2025 10:37

yrobla requested review from JAORMX and dmjb

June 2, 2025 10:38

JAORMX reviewed

View reviewed changes

pkg/container/docker/client.go Show resolved Hide resolved

pkg/permissions/profile.go Outdated Show resolved Hide resolved

yrobla requested a review from JAORMX

June 3, 2025 08:26

yrobla force-pushed the issue-124 branch from cc53542 to f5d6106 Compare

June 3, 2025 09:05

JAORMX reviewed

View reviewed changes

pkg/container/docker/client.go Outdated Show resolved Hide resolved

yrobla requested a review from JAORMX

June 4, 2025 09:56

yrobla force-pushed the issue-124 branch 2 times, most recently from b2a5b5a to c266a00 Compare

June 4, 2025 10:06

dmjb reviewed

View reviewed changes

pkg/lifecycle/manager.go Outdated Show resolved Hide resolved

dmjb reviewed

View reviewed changes

pkg/container/docker/client.go Show resolved Hide resolved

dmjb requested changes

View reviewed changes

pkg/container/docker/client.go Outdated Show resolved Hide resolved

yrobla force-pushed the issue-124 branch from 0742bf5 to 6708f85 Compare

June 4, 2025 13:49

yrobla force-pushed the issue-124 branch 5 times, most recently from 081235b to 1307316 Compare

June 11, 2025 10:57


          spin egress container for each mcp server

ce4d2ea

Closes: #124

spin up and connect networks

move logic to internal docker

fixes from rebase

fix squid.conf

fix lint

move egress into deploy workload

move pull image

move stop container task

changes from review

add dns container

remove not used profile

modify thv list

resolve ingress connectivity

fix inspector

fixes from review

fix error range

remove gocyclo warnings

fix tests

properly stop and remove containers

add more verbose tests

change docker image

update swagger

retry on cleaning resources

fix swagger

add more timeout to osv

changes for debug

yrobla force-pushed the issue-124 branch 2 times, most recently from eb21d58 to e294fc2 Compare

June 11, 2025 11:07


          change order of containers

73749da

add debug

yrobla force-pushed the issue-124 branch from e294fc2 to 73749da Compare

June 11, 2025 11:29


          label auxiliary workloads instead of main

6e068c7

yrobla force-pushed the issue-124 branch 5 times, most recently from ccdddaa to 7ddb0be Compare

June 11, 2025 14:47


          Small changes to the egress proxy code (#709)

b082d51

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
Co-authored-by: Yolanda Robla <info@ysoft.biz>

yrobla force-pushed the issue-124 branch from 7ddb0be to b082d51 Compare

June 11, 2025 14:55


          create independent ingress proxy

bb043d0

yrobla force-pushed the issue-124 branch from 6e2a054 to bb043d0 Compare

June 12, 2025 09:42

yrobla requested review from dmjb and rdimitrov

June 12, 2025 09:59


          Merge branch 'main' into issue-124

07ed0af

dmjb approved these changes

View reviewed changes


          Merge branch 'main' into issue-124

ae8b096

yrobla dismissed JAORMX’s stale review

June 13, 2025 10:50

does not apply anymore

yrobla merged commit 4e3c163 into main

13 checks passed

yrobla deleted the issue-124 branch

June 13, 2025 11:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet