Skip to content

Tests: Update test expectation - take 2 #8899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Tests: Update test expectation - take 2 #8899

wants to merge 1 commit into from

Conversation

bkhouri
Copy link
Contributor

@bkhouri bkhouri commented Jul 7, 2025 •
edited
Loading

Update test expectation for executing SwiftPM tests in the Windows Platform Test PR build - the script found in https://github.com/swiftlang/swift/blob/main/utils/build.ps1.

Relates to: swiftlang/swift#82274

@bkhouri bkhouri mentioned this pull request Jul 7, 2025
Open
@bkhouri
Copy link
Contributor Author

bkhouri commented Jul 7, 2025

@swift-ci test

@bkhouri bkhouri marked this pull request as ready for review July 7, 2025 20:10
@bkhouri bkhouri marked this pull request as draft July 9, 2025 04:37
@bkhouri bkhouri force-pushed the t/main/update_swiftpm_tests_for-build.ps1 branch from 6730578 to 4793ca9 Compare July 9, 2025 13:53
@bkhouri
Copy link
Contributor Author

bkhouri commented Jul 9, 2025

@swift-ci test

@bkhouri
Copy link
Contributor Author

bkhouri commented Jul 9, 2025

swiftlang/swift#82274

@swift-ci test windows

@bkhouri
Tests: Update test expectation - take 2
8bc2689 
Update test expectation for executing SwiftPM tests using the build.ps1
script found in swiftlang/swift/utils/build.ps1.

Relates to: swiftlang/swift#80405
@bkhouri bkhouri force-pushed the t/main/update_swiftpm_tests_for-build.ps1 branch from 4793ca9 to 8bc2689 Compare July 10, 2025 13:39
@bkhouri
Copy link
Contributor Author

bkhouri commented Jul 10, 2025

swiftlang/swift#82274

@swift-ci test

@bkhouri
Copy link
Contributor Author

bkhouri commented Jul 10, 2025

@swift-ci test windows

@bkhouri
Copy link
Contributor Author

bkhouri commented Jul 10, 2025

swiftlang/swift#82274

@swift-ci test windows

@bkhouri
Copy link
Contributor Author

bkhouri commented Jul 11, 2025

Previous windows platform build failed with the following

× Test percentFormatStyle_Consumer() recorded an issue at NumberFormatStyleTests.swift:1866:24: Expectation failed: (upperBound → nil) == (expectedUpperBound → 3[utf8])

→ found upperBound: nil; expected: Optional(3)

× Test percentFormatStyle_Consumer() recorded an issue at NumberFormatStyleTests.swift:1866:24: Expectation failed: (match → nil) == (expectedValue → 42)

Let's retriever and see what happens.

swiftlang/swift#82274

@swift-ci test windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakepetroules jakepetroules Awaiting requested review from jakepetroules jakepetroules is a code owner

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand is a code owner

@owenv owenv Awaiting requested review from owenv owenv is a code owner

@cmcgee1024 cmcgee1024 Awaiting requested review from cmcgee1024 cmcgee1024 is a code owner

@daveyc123 daveyc123 Awaiting requested review from daveyc123 daveyc123 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bkhouri