Fixed closure compiled output for safari (#290)

torch2424 · web-flow · commit 94c635e5d22b · 2019-05-01T01:11:23.000-07:00
diff --git a/lib/audio/gbchannel.js b/lib/audio/gbchannel.js
@@ -48,7 +48,9 @@ export default class GbChannelWebAudio {
       this.audioContext = new (window.AudioContext || window.webkitAudioContext)();
 
       // Set up our nodes
-      if (this.audioContext) {
+      // Seems like closure compiler will optimize this out
+      // Thus, need to do a very specifc type check if statement here.
+      if (!!this.audioContext === true) {
         this.gainNode = this.audioContext.createGain();
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,9 @@ export default class GbChannelWebAudio {`
`48`	`48`	`this.audioContext = new (window.AudioContext \|\| window.webkitAudioContext)();`
`49`	`49`
`50`	`50`	`// Set up our nodes`
`51`		`- if (this.audioContext) {`
	`51`	`+ // Seems like closure compiler will optimize this out`
	`52`	`+ // Thus, need to do a very specifc type check if statement here.`
	`53`	`+ if (!!this.audioContext === true) {`
`52`	`54`	`this.gainNode = this.audioContext.createGain();`
`53`	`55`	`}`
`54`	`56`	`}`