Skip to content

fix(import): curl parser library #4959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

maintainer-bruno
Copy link
Collaborator

@maintainer-bruno maintainer-bruno commented Jun 23, 2025

Description

This PR rewrites the cURL command parser with improved support and better parsing accuracy for various cURL commands. It maintains backward compatibility and includes comprehensive test coverage.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

JIRA
GH Issues:

@helloanoop
Copy link
Contributor

PR looks awesome!

Is there a reason why we would want to still keep 2 top level describe blocks parseCurlCommand and parseCurlCommand v2 ? Looking at the expects, I believe we should be deleting the older tests since you are comprehensively covering them in your newer tests

image

@maintainer-bruno maintainer-bruno force-pushed the feat/curl-parser branch 3 times, most recently from 4013de2 to b4dbf29 Compare June 23, 2025 19:35
@lohit-bruno lohit-bruno merged commit 674820f into usebruno:main Jun 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants