Skip to content

fix: VideoJS 8 support #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: VideoJS 8 support #396

wants to merge 3 commits into from

Conversation

dds05
Copy link

@dds05 dds05 commented Mar 17, 2025

Description

Allow videojs 8

Specific Changes proposed

  1. Added videojs 8 in dependency in package.json.
  2. Remove videojs.merge options from src/js/ttml-text-track-display.js
  3. Updated rollup and videojs-generate-rollup-config versions.
  4. Changes in rollup.config.js to avoid transpilation to es5.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Unit Tests updated or fixed
    • Docs/guides updated
  • Reviewed by Two Core Contributors

@dds05 dds05 changed the title fix: V8 support fix: VideoJS 8 support Mar 17, 2025
@dds05
Copy link
Author

dds05 commented Mar 17, 2025

@gkatsev , @philjhale Let me know if something else needs to be changed.

@dds05 dds05 mentioned this pull request Mar 17, 2025
5 tasks
@dds05
Copy link
Author

dds05 commented Apr 1, 2025

@alex-barstow Can you please take a look on this?

@nimeshjohri-viewlift
Copy link

nimeshjohri-viewlift commented Apr 3, 2025

@gkatsev @alex-barstow

Any update on this PR on when this will be merged, as I am having the same issue with videoJS8?

@mister-ben
Copy link

This isn't sufficient yet for Video.js 8 compatibility. The same issue mentioned before will need to be addressed. The build needs to not transpire ES6 classes. This will likely need updates to several dependencies.

@dds05
Copy link
Author

dds05 commented Apr 8, 2025

Okay @mister-ben . Let me try by updating videojs-generate-rollup-config version.

@dds05
Copy link
Author

dds05 commented Jun 22, 2025

@mister-ben Can you please take a look? Let me know if any further changes are needed.

@Ammy016
Copy link

Ammy016 commented Jun 25, 2025

@gkatsev I am having the same problem with VideoJS-8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants