Add Centaurus cluster related features in Centaurus dashboard #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
click2cloud-varsha
force-pushed
the
centaurus
branch
2 times, most recently
from
a101e3f to
62b4398
Compare
click2cloud-varsha
force-pushed
the
centaurus
branch
from
0090395 to
1e1400c
Compare
|
@sonyafenge Please review. We have added some more fixes that we have identified. Thanks |
click2cloud-amit
force-pushed
the
centaurus
branch
from
27a083b to
1d3fa52
Compare
sonyafenge
reviewed
Apr 22, 2022
| @@ -255,7 +255,7 @@ func DeleteAllUser() int64 { | |||
| defer db.Close() | |||
|
|
|||
| // create the delete sql query | |||
| sqlStatement := `DELETE * FROM userdetails` | |||
| sqlStatement := `DELETE FROM userdetails` | |||
There was a problem hiding this comment.
is this changing correct? what is deleted?
There was a problem hiding this comment.
Yes, with * it gives error,Thanks
sonyafenge
reviewed
Apr 22, 2022
| "golang.org/x/net/xsrftoken" | ||
| v1 "k8s.io/api/core/v1" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| "k8s.io/client-go/tools/remotecommand" |
There was a problem hiding this comment.
bunch of format changing, is this necessary?
|
please check all format changing and confirm if these are necessaary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for content-related feature in dashboard: