-
Notifications
You must be signed in to change notification settings - Fork 72
Ahrefs Web Analytics integration #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: f2616a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Few comments before we can merge it :)
Co-authored-by: Taran Vohra <taranvohra@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just applied suggestions from code review. I think we should refrain from using js.dataset['data-key']
though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a lockfile is broken. Can you fix that?
commit: |
Close: #773
Hopefully, this serves as a starting point for the requested Ahrefs integration. I haven't tested it thoroughly, so feel free to amend this PR if needed or close it altogether if you'd rather not pursue this integration.