-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Support devEngines
field in package.json
#1255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @zanminkian , Thank you for creating this feature request. We will investigate it and provide feedback as soon as we have some updates. |
And if anyone is working on this, maybe you could also consider factoring in the volta node field? ![]() Then you could run https://docs.volta.sh/reference/pin But maybe it would be better to let volta handle the devEngines update instead of making this action volta-aware |
Uh oh!
There was an error while loading. Please reload this page.
Description:
devEngines
field is now supported by npm and corepack.If user set
node-version-file: package.json
in yaml,setup-node
action should consult bothengines
anddevEngines
fields, while currently onlyengines
works.Justification:
In monorepo, the root package.json usually have no
engines
field. Moreover, theengines
is for users who install the npm package, while thedevEngines
field is for who developers who develop the npm package. Obviously,devEngines
is more suitable forsetup-node
.Are you willing to submit a PR?
Yes
The text was updated successfully, but these errors were encountered: