mirror option does not work correctly

[thomasmey]

the mirror option does not work, it has those bugs:

1. To the mirror URL silently the path segment "/dist" is appended, this is bad and assumes that the mirror URL is under full control, but in case that the mirror URL mirrors "/dist" path directly the mirror option cannot be used anymore, e.g. https://mirror.example.com/node-dist/ will mirror https://nodejs.org/dist
2. When running in a self hosted action runner in private network without direct internet connectivity, the mirror option does not work. The getInfoFromManifest will timeout waiting for GitHub to not be reachable and the else branch for "Falling back to download directly from ' will never been reached.

Action version:
v4

Platform:

• Ubuntu
• macOS
• Windows

Runner type:

• Hosted
• Self-hosted

Tools version:

Repro steps:
A description with steps to reproduce the issue. If you have a public example or repo to share, please provide the link.

Expected behavior:
A description of what you expected to happen.

Actual behavior:
A description of what is actually happening.

[aparnajyothi-y]

Hello @thomasmey, Thank you for creating this issue and we will look into it :)

[priyagupta108]

Hi @thomasmey 👋,
Thanks for raising these points. Here's some context and current thinking around them:

1. Mirror URL Automatically Appending /dist:
   This behavior is intentional. The setup-node team, in coordination with the Node.js team, chose this design for consistency and standardization. The goal was to accommodate the majority of use cases and simplify configuration for most users.

2. Timeout in Private Networks:
   The action attempts to fetch version from GitHub (getInfoFromManifest) before falling back to direct download. If GitHub is unreachable, the request will time out, and unfortunately, the mirror download path isn't triggered due to the way the fallback logic is structured.
   As a workaround, please try configuring the HTTPS_PROXY (or HTTP_PROXY) environment variable to route requests through a proxy server. It might help in environments with restricted outbound access. For guidance, see GitHub’s documentation on using a proxy with self-hosted runners.

[priyagupta108]

Hi @thomasmey 👋,
Just a quick follow-up on the previous comment. Hope this clarifies things! Please let us know if there are any concerns or further questions.
Thanks!

[thomasmey]

Hi, @priyagupta108 sad to hear that Microsoft has no intention to fix those bugs, looks like I need use my fixed private fork for much longer now

[priyagupta108]

Hi @thomasmey ,
Thank you for your follow-up and feedback.
We understand that the current approach doesn’t fully meet your use case. As mentioned earlier, this behavior was designed in collaboration with the Node.js team for consistency and ease of use for the majority of users. While this works for most cases, we understand that some scenarios may require more flexibility. We’ll continue to monitor feedback on this, but for now, this design remains in place to ensure broader compatibility.

Closing this issue for now, but feel free to reach out if you have any further questions or concerns. Thank you!