Skip to content

config-default.conf no longer read by default? #6374

Open
@matthijskooijman

Description

@matthijskooijman

What happened?

I recently upgraded my build repo from an old version, and it seems it no longer reads userpatches/config-default.conf by default when I run ./compile.sh. When I explicitly specify it with ./compile.sh default it does get read.

Maybe this is intentional and the idea is to now always specify a config name, but the docs seem to suggest (though a bit vaguely) that config-default.conf should be loaded by default:

After the first run of compile.sh a new configuration file config-example.conf and symlink config-default.conf will be created. You may edit it to your needs or create different configuration files using it as a template.

Looking at the code, it seems the config filename(s) are stored in $ARMBIAN_CONFIG_FILES, but that has no default value and values only get added from commandline arguments, so it seems the code is not even trying to load config-default.conf by default (which might make this is a documentation bug). See https://github.com/search?q=repo%3Aarmbian%2Fbuild+ARMBIAN_CONFIG_FILES&type=code

How to reproduce?

./compile.sh

Branch

main (main development branch)

On which host OS are you observing this problem?

Other

Relevant log URL

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions