Closed
Description
What happened?
I chose to dive into uboot breakage using Noble build host so I chose a random one from here: #6862 (comment)
Found a patch that seem to work. Though I did not check if either this even works besides successful build or if this breaks jammy.
Both needs testing before applying.
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
Date: Wed, 7 May 2025 09:13:39 +0000
Subject: cmd: inconsistent return type of command_process()
Reported-by: Sergei Antonov <saproj at gmail.com>
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
Borrowed-by: Werner <werner at armbian.com>
---
include/command.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/command.h b/include/command.h
index 681084b9ea3..a47a282143c 100644
--- a/include/command.h
+++ b/include/command.h
@@ -137,13 +137,12 @@ enum command_ret_t {
* is left unchanged.
* @param ticks If ticks is not null, this function set it to the
* number of ticks the command took to complete.
* @return 0 if the command succeeded, 1 if it failed
*/
-int cmd_process(int flag, int argc, char * const argv[],
+enum command_ret_t cmd_process(int flag, int argc, char *const argv[],
int *repeatable, unsigned long *ticks);
-
void fixup_cmdtable(cmd_tbl_t *cmdtp, int size);
/**
* board_run_command() - Fallback function to execute a command
*
--
Created with Armbian build tools https://github.com/armbian/build
How to reproduce?
Build uboot on Noble for this board and watch yourself failing miserabely.
Branch
main (main development branch)
On which host OS are you running the build script and observing this problem?
Ubuntu 24.04 Noble
Are you building on Windows WSL2?
- Yes, my Ubuntu/Debian/OtherOS is running on WSL2
Relevant log URL
No response
Code of Conduct
- I agree to follow this project's Code of Conduct