lib distro-specific.sh: move armbian GPG to more common location

[leggewie]

The armbian GPG key should be at /usr/share/keyrings/armbian-archive-keyring.gpg not /usr/share/keyrings/armbian.gpg, I think. That'd be in line with where Ubuntu and Debian ship theirs.

I've already made a change in APA for the armbian-common package to ship the key in the new location but make a symlink from the old and hence work with both scenarios.

[coderabbitai]

Walkthrough

The change modifies the filename used for the Armbian APT signing keyring in the create_sources_list_and_deploy_repo_key function within the lib/functions/rootfs/distro-specific.sh script. Specifically, it updates the path from /usr/share/keyrings/armbian.gpg to /usr/share/keyrings/armbian-archive-keyring.gpg for storing the GPG key after conversion to binary format using gpg --dearmor. The updated filename is also reflected in the Signed-By field within the Armbian APT repository source list. No other aspects of the function, such as logic, error handling, or control flow, are changed.

Suggested labels

ready to merge

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

lib/functions/rootfs/distro-specific.sh (1)

164-165: Align Armbian GPG key path and enhance gpg --dearmor invocation
The APT_SIGNING_KEY_FILE variable now points to /usr/share/keyrings/armbian-archive-keyring.gpg, which correctly follows Debian/Ubuntu conventions. To improve consistency and robustness:

1. Scope the variable locally within the function to avoid polluting the global namespace:

-APT_SIGNING_KEY_FILE="/usr/share/keyrings/armbian-archive-keyring.gpg"
+declare APT_SIGNING_KEY_FILE="/usr/share/keyrings/armbian-archive-keyring.gpg"

2. Make the dearmor step non-interactive by adding --batch (and --yes if desired) to prevent unexpected prompts during automated builds:

-gpg --dearmor < "${SRC}"/config/armbian.key > "${basedir}${APT_SIGNING_KEY_FILE}"
+gpg --batch --dearmor < "${SRC}"/config/armbian.key > "${basedir}${APT_SIGNING_KEY_FILE}"

Finally, please verify that the corresponding armbian-common package indeed installs the de-armored key (or symlink from the old armbian.gpg path) at this new location on target systems.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a4b1edd and 91ae22d.

📒 Files selected for processing (1)

• lib/functions/rootfs/distro-specific.sh (1 hunks)