fix: change slot recipe raw function typings #3291
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
SlotRecipeRuntimeFn
'sraw()
function uses a return type that seems unnecessary to be different from the props' type; especially since the respective js generated (as seen in generator artifacts) is simply justraw: (props) => props
. Correcting this would make working with slot recipe types easier as you can map the generic types to the actual slot recipe types that are being generated.⛳️ Current behavior (updates)
The generic SlotRecipeRuntimeFn's
raw()
return type isRecord<S, SystemStyleObject>
which is not a proper match toRecipeSelection<T>
🚀 New behavior
Return type uses the
RecipeSelection<T>
.💣 Is this a breaking change (Yes/No):
No
📝 Additional Information