Skip to content

fix: change slot recipe raw function typings #3291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

firzanarmani
Copy link
Contributor

📝 Description

SlotRecipeRuntimeFn's raw() function uses a return type that seems unnecessary to be different from the props' type; especially since the respective js generated (as seen in generator artifacts) is simply just raw: (props) => props. Correcting this would make working with slot recipe types easier as you can map the generic types to the actual slot recipe types that are being generated.

⛳️ Current behavior (updates)

The generic SlotRecipeRuntimeFn's raw() return type is Record<S, SystemStyleObject> which is not a proper match to RecipeSelection<T>

🚀 New behavior

Return type uses the RecipeSelection<T>.

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Copy link

changeset-bot bot commented Jun 22, 2025

⚠️ No Changeset found

Latest commit: a721118

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jun 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
panda-docs ✅ Ready (Inspect) Visit Preview Jun 22, 2025 6:52am
panda-playground ✅ Ready (Inspect) Visit Preview Jun 22, 2025 6:52am
panda-studio ✅ Ready (Inspect) Visit Preview Jun 22, 2025 6:52am

@segunadebayo
Copy link
Member

This is incorrect. sva.raw(...) actually returns the css object for each slot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants