Use spans in low level lexer char array handling code #79232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Jul 2, 2025
| char[] textBuffer, | ||
| int keyStart, | ||
| int keyLength, | ||
| ReadOnlySpan<char> textBuffer, |
There was a problem hiding this comment.
much cleaner to just pass spans all the way through. in the bowels that's all we were using the array+start+length for anyways.
CyrusNajmabadi
commented
Jul 2, 2025
|
|
||
| return hashCode; | ||
| } | ||
| => GetFNVHashCode(text.AsSpan(start, length)); |
There was a problem hiding this comment.
we already have the overload that works on a ROS. just defer to that.
|
@dotnet/roslyn-compiler this is ready for review. |
CyrusNajmabadi
commented
Jul 2, 2025
| { | ||
| var span = chars.AsSpan(start, len); |
There was a problem hiding this comment.
note that these layers were also often using spans. Now they don't use spans partially for some op, and array+start+length for others. They use spans consistently through teh entire path.
RikkiGibson
approved these changes
Jul 2, 2025
Thanks. Fixed @RikkiGibson |
|
@chsienki ptal. |
chsienki
approved these changes
Jul 2, 2025
RikkiGibson
pushed a commit
that referenced
this pull request
Jul 3, 2025
CyrusNajmabadi
added a commit
to CyrusNajmabadi/roslyn
that referenced
this pull request
Jul 3, 2025
…t#79232)" (dotnet#79245) This reverts commit bdc869e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while doing work in simplifying the lexer/sliding-text-window code. As these are all about efficiently workign with contiguous segments of characters, this fell out as a nice simplification.
Note that a bunch of this code was already span-ified previously. This just pushes that spanification higher to some internal component boundary points.