-
Notifications
You must be signed in to change notification settings - Fork 1k
Add code coverage for DataGridViewComboBoxCell #13654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add code coverage for DataGridViewComboBoxCell #13654
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13654 +/- ##
===================================================
+ Coverage 76.60680% 76.71642% +0.10961%
===================================================
Files 3253 3256 +3
Lines 641011 641787 +776
Branches 47442 47502 +60
===================================================
+ Hits 491058 492356 +1298
+ Misses 146303 145768 -535
- Partials 3650 3663 +13
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new unit test file to improve code coverage for the DataGridViewComboBoxCell component. The tests cover default values, property setters, exception throwing conditions, and behavior of key interactions and formatting methods.
- Added new unit tests for public and protected methods of DataGridViewComboBoxCell.
- Validated correct exception types and property behaviors.
- Ensured behavior consistency when changing properties under various conditions.
Comments suppressed due to low confidence (1)
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxCellTests.cs:7
- Consider refactoring to a file-scoped namespace definition (e.g. 'namespace System.Windows.Forms.Tests;') to simplify the code structure as recommended by modern C# practices.
namespace System.Windows.Forms.Tests;
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxCellTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxCellTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxCellTests.cs
Outdated
Show resolved
Hide resolved
src/test/unit/System.Windows.Forms/System/Windows/Forms/DataGridViewComboBoxCellTests.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Related #13442
Proposed changes
Add unit test file:DataGridViewComboBoxCellTest.cs for public/protected methods of the DataGridViewComboBoxCell.cs
Microsoft Reviewers: Open in CodeFlow