Skip to content

Relax json schema validation #2878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

Conversation

MihaZupan
Copy link
Member

This removes a couple false positive errors from the schema config validation:

  • It's fine to define bools in json as strings "true"/"false" instead of just true/false
  • TimeSpans can parse without leading zeros - 00:2:3 is an acceptable alternative to 00:02:03
  • Metadata values can be non-strings in json. E.g. "foo": 42 is okay instead of "foo": "42"

@MihaZupan MihaZupan added this to the YARP 3.0 milestone Jun 19, 2025
@MihaZupan MihaZupan requested a review from benjaminpetit as a code owner June 19, 2025 21:08
@MihaZupan MihaZupan merged commit 452f1a7 into dotnet:main Jun 23, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants