Skip to content

redact passwords from logs correcrtly #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MegaManSec
Copy link

also return an opts if possible.

@MegaManSec MegaManSec requested a review from a team as a code owner May 30, 2025 17:11
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an actual bug being fixed here? If so, can we add tests for that case? On initial glance this just looks like an alternative implementation to do the same thing.

@MegaManSec
Copy link
Author

Is there an actual bug being fixed here

Yes. A couple of things:

  1. -P=password and --password=password (and etc.) were not redacted previously,
  2. -P 'abc def' would only redact abc.
  3. -P abc -P def would only redact abc -- of course, this is user error, but I thought why not patch it anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants