Skip to content

Misleading error message for file count mismatch #103

Open
@erickzhao

Description

@erickzhao

The initial implementation for this library (163f495) threw an error if the count of Mach-O files was different between .app bundles.

'While trying to merge mach-o files across your apps we found a mismatch, the number of mach-o files is not the same between the arm64 and x64 builds',

In (46ff9c4), the scope of this check was widened to account for any file that wasn't an app.asar archive or a .bin V8 snapshot.

const dupedFiles = (files: AppFile[]) => files.filter(f => f.type !== AppFileType.SNAPSHOT && f.type !== AppFileType.APP_CODE);

However, the initial error message has not changed, which can be misleading for users encountering it.

I'm not sure if we only care about Mach-O files here and should also filter out AppFileType.PLAIN files in this check, or if the error message should be clarified instead.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions