windows-sign param throwing error when using `hookModulePath`

[barkinoaa]

Description

Using the windows-sign parameter in the createWindowsInstaller() function of electron/windows-installer, seems to throw an error in SEA_MAIN_SCRIPT. The windows-sign parameter is added in the createWindowsInstaller function here.

Upon inspection of the source code of the windows-sign module, it appears that it throws an error at SEA_MAIN_SCRIPT, see here: SEA_MAIN_SCRIPT - sea.ts. Furthermore, the error message lacks any informative details; instead, it only logs "electron-windows-sign Called with options ..." (refer to sign.ts). It was only after removing these logs that the actual error message became apparent: 'SignTool Error: File not found: windows-sign'."

This issue arises when using hookModulePath.

[AndyDean96]

Adding a little bit of context here, as I ran into a very similar problem. I had debug enabled and was using my own instance of signtool.exe. What this meant was windows-sign began logging to stderr, which in turn appears to be the check here to see if the spawned process failed.

This caused an error to be thrown, even though signtool.exe completed successfully. I think a fix would be to check the exitStatus of the subprocess instead of stderr.

[eliandoran]

This appears to have been solved in c2a0c78, where the check for stderr was replaced with an exit code check instead.