Open
Description
No matter what options you have, signWithSignTool
always adds hashing/timestampServer params.
windows-sign/src/sign-with-signtool.ts
Lines 25 to 31 in 2605684
Then if you signWithParams
with the same params (e.g. /td sha256
), signing results in error because duplicating params in signtool
is not allowed.
I think this would be good if developers can provide any params in signWithSignTool
. Especially because README makes a feeling it is possible:
Lines 231 to 237 in 2605684
Probably related: Squirrel/Squirrel.Windows#1742
Proposal
After parsing signWithParams
, replace duplicating params.
If this is fine, I'm ready to make a PR.
Metadata
Metadata
Assignees
Labels
No labels