Skip to content

Sync problem specs #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 14, 2025
Merged

Sync problem specs #753

merged 3 commits into from
Jun 14, 2025

Conversation

BNAndras
Copy link
Member

@BNAndras BNAndras commented Jun 9, 2025

Here are the results of running ./bin/configlet sync --docs --metadata --tests include -uy. The two new largest-series-product tests just change the expected error messages for those two situations, but the track expects Nothing returned, so there's no need to update the tests themselves.

Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good.
I must ask, should we consider changing largest-series-product so that it returns errors instead of a maybe?

@jiegillet jiegillet merged commit 955ebdd into exercism:main Jun 14, 2025
7 checks passed
@BNAndras BNAndras deleted the sync-problem-specs branch June 14, 2025 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants