Practice exercise sync

[colinleach]

After reading some recent forum posts, I got curious and ran configlet sync on the Julia repo. Apparently, we have lots of unsynced docs and missing test cases.

The docs are easy, and I'll prepare a PR for those. Updating the tests means actually work for us, since auto-generate was never really implemented (just some bits).

[colinleach]

Docs are addressed in #949

For missing test cases, this seems to be the TODO list:

• all-your-base: missing 21 test cases
• allergies: missing 1 test case
• anagram: missing 8 test cases
• armstrong-numbers: missing 2 test cases
• bob: missing 1 test case
• collatz-conjecture: missing 2 test cases
• complex-numbers: missing 9 test cases
• custom-set: missing 2 test cases
• gigasecond: missing 1 test case
• hamming: missing 6 test cases
• isbn-verifier: missing 2 test cases
• largest-series-product: missing 2 test cases
• luhn: missing 4 test cases
• matching-brackets: missing 1 test case
• phone-number: missing 4 test cases
• pig-latin: missing 1 test case
• resistor-color-trio: missing 5 test cases
• reverse-string: missing 3 test cases
• roman-numerals: missing 1 test case
• triangle: missing 2 test cases
• word-count: missing 2 test cases

Looks substantial! I'm unconvinced about how urgent it is, compared with all the syllabus stuff.

It isn't an all-at-once upgrade. We could take one exercise at a time, and configlet supports that.

[depial]

I would assume this is a lower priority than syllabus stuff as well. Luckily most of them are just a couple of test cases too.

[depial]

There only remains complex-numbers, which I would like to discuss...

Most of the missing tests are related to arithmetic between ComplexNumber and regular numbers, but the instructions explicitly list what will be tested and everything is between ComplexNumbers.

I assume this is because there is an additional layer of dealing with promotion that the author of the exercise didn't want to deal with. I currently see four possibilities:

1. Leave the tests as they are (i.e. set the missing tests to include = false in tests.toml to fix the configlet issue)
2. Include the tests in an @test_skip group (which already exists for other tests in the testset)
3. Make them bonus tests, which the student can activate.
4. Include them as mandatory, changing the requirements of the exercise.

I'm more leaning towards either Option 1 or Option 3. What do you think?

[colinleach]

the instructions explicitly list what will be tested and everything is between Complex Numbers.

Unfortunate. I've done this exercise on several other tracks, and the mixed-input aspect is a significant part of the challenge. Maybe less in Julia, with multiple dispatch.

FYI, 249 students have completed the exercise in its current form. A significant number of solutions to break, but not like the 1202 on Python.

I don't have strong feelings, but I lean towards option 3.

[depial]

I think Option 3 is sounding pretty good.

I saw that Rational Numbers requires promotion rules, so I'm less inclined to force students to write one for this exercise, but it would be good to give them the opportunity to use that knowledge.

Anyway, we don't have to resolve this now, so we can think about it for a while, since I think the instructions will end up needing a revamp as well.

[colinleach]

I felt a sudden nervousness about who wrote Roman Numerals for Julia - it's the sort of thing I might have done in the past. Happily, it's 9 years old. There were updates to the test file last year ... by you. I guess this gives you even more authority in changing the tests now!

[depial]

I believe we can close this for now.