Update series
tests and example
#279
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No canonical tests were being used hence the almost complete overhaul. There is only one completion for this exercise to date so we won't break a whole lot here.
I implemented all the tests, but we can discuss that. Do we want the error validation tests? Should they be errors or should we return false values here.
I kept the expected argument order the same from before even though the problem specs has the series first and then the slice. Should we swap?
Does
series:from-string
make sense as a name? The tested property isslices
so we can change it.