[Feature request] Add optional charmap argument to `INCHARMAP`

[dannye]

There is currently:

INCHARMAP(str) Returns 1 if str has an entry in the current charmap, and 0 otherwise.

I am proposing adding:

INCHARMAP(str, charmap) Returns 1 if str has an entry in the specified charmap, and 0 otherwise.

It would be convenient for me to be able to test if a character is in a charmap before switching to it.

[Rangi42]

Charmap names are not generally used as strings, e.g. newcharmap ascii or setcharmap unown or pushc main. So it would be weird for the second arg here to be a quoted string, but also weird for a function to take an identifier as an arg.

Would this suffice?

MACRO check_charmap
	pushc \2
	def _in_charmap = INCHARMAP(\1, \2)
	popc
ENDM

check_charmap "<CHR>", french
if _in_charmap
	...
endc

[Rangi42]

INCHARMAP also isn't the only charmap-dependent function; there's also CHARLEN, CHARCMP, CHARSIZE, and (in 0.9.3 soon) CHARVAL. I don't think we want to add a parameter to all of them.

[dannye]

INCHARMAP also isn't the only charmap-dependent function; there's also CHARLEN, CHARCMP, CHARSIZE, and (in 0.9.3 soon) CHARVAL. I don't think we want to add a parameter to all of them.

Yeah, I agree. I think INCHARMAP is arguably the one that gets the most benefit from having a sort of "peek" option. I think it would be overkill to add the parameter to all of them.

Charmap names are not generally used as strings, e.g. newcharmap ascii or setcharmap unown or pushc main. So it would be weird for the second arg here to be a quoted string, but also weird for a function to take an identifier as an arg.

Would this suffice?
[...]

I don't think it would necessarily be that weird for the function to take an identifier (I say as an outsider).

But yeah, that workaround is essentially what I've been tinkering with for now. Feel free to close this if you decide it's not worth it.

[Rangi42]

Yeah, I'd rather not add a new kind of argument for this one function. If this is desired for poketcg, I can check out the workaround later and see if it can be improved.