-
Notifications
You must be signed in to change notification settings - Fork 83k
Addition of ColdBox HMVC Framework #3642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This PR is stale because there have been no updates in 90 days. It will close after 180 days of inactivity. Leave a comment if you want to keep it open 😄 |
We typically don't house gitignore templates for frameworks in our root directory. |
ColdBox.gitignore
Outdated
@@ -0,0 +1,27 @@ | |||
# General Ignores + IDE | |||
.DS_Store |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove this OS specific line? We encourage people to instead use global gitignore configs and have a collection of them that can be used. Please see our Global/README for more information and Global/macOS.gitignore for an example.
Thanks so much for the feedback @wirecat . I updated the ignores to the latest versions.
With that said, you have already 36 frameworks in the root?
|
@lmajano we haven't always got it right, but we're trying to uphold the standards passed down to us from previous maintainers. In some of the examples you've provided, those frameworks definitely don't feel like the right fit in root to me now, but someone made that call back in the day. Rails and WordPress feel like good examples that I would commit to root, as they are extremely common frameworks in the industry. If you feel ColdBox should be placed in root, we need good justification on why. Does it have a large userbase? Lots of forks? etc. I see it being used, but it hasn't quite reached the level of widespread use that would make me pull it into root. It's unfortunately rather subjective, but it's the best we can do to prevent root from being flooded with templates. |
Thanks so much for the thoughtful response, @wirecat — I really appreciate the stewardship you're providing for the project and your desire to avoid bloat in the root. It sounds like you’re trying to maintain a high bar for inclusion, which I completely respect. It seems like the concern is whether ColdBox has the kind of adoption and ecosystem to justify root placement — is that fair to say? ColdBox has been the de facto standard MVC framework for the CFML language for more than 20 years and, as of 2024, it also supports BoxLang, a modern JVM dynamic language designed for multi-runtime environments. It's been around for nearly two decades, with a rich ecosystem of libraries, tooling, and educational resources. It has become central to how many developers build web apps and APIs in the CFML and JVM spaces. What’s the best way forward from your point of view? |
Reasons for making this change:
Adding support for the ColdBox HMVC Framework for ColdFusion (CFML)
Links to documentation supporting these rule changes:
https://coldbox.ortusbooks.com/
If this is a new template:
Link to application or project’s homepage:
https://www.coldbox.org
https://github.com/coldbox/coldbox-platform
https://community.ortussolutions.com
https://coldbox.ortusbooks.com/