Skip to content

Update Node.gitignore #4303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update Node.gitignore #4303

wants to merge 2 commits into from

Conversation

lwabish
Copy link

@lwabish lwabish commented May 29, 2023

Reasons for making this change:

Is it a little arbitrary to ignore logs directory?
In golang ,some common packages name themselves as logs, for example, k8s.io/component-base/logs

remove logs directory
@cyber-amr
Copy link

Ignoring the logs dir in the root dir instead of ignoring it globally won't be better?

as:

/logs

@lwabish
Copy link
Author

lwabish commented Dec 14, 2023

Ignoring the logs dir in the root dir instead of ignoring it globally won't be better?

as:

/logs

Seems good

@lwabish
Copy link
Author

lwabish commented Dec 21, 2023

Ignoring the logs dir in the root dir instead of ignoring it globally won't be better?

as:

/logs

I have updated this PR according to this suggestion, which changed logs to /logs

Copy link

github-actions bot commented Jun 9, 2025

This PR is stale because there have been no updates in 90 days. It will close after 180 days of inactivity. Leave a comment if you want to keep it open 😄

@github-actions github-actions bot added the stale label Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants