Add .DS_Store to Swift, ObjC & Xcode gitignores #4669
Closed
+9
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
I've spent years manually adding
.DS_Store
to every.gitignore
I've created fromSwift.gitignore
so those (seemingly) meaningless files don't get included, maybe I'm missing a reason that they've been left in, though they're excluded from theGlobal/macOS.gitignore
, so assume they should also be excluded in these templates?I assume it's ok to "ignore" the contribution guideline regarding only one template change per PR, seeing as the templates being changed say to also change the other ones? If not I can raise them separately, but it seems relevant to keep them all in one PR for a single change to each like this.
Links to documentation supporting these rule changes
Hope this suffices, let me know if not!
Merge and Approval Steps