Skip to content

Add .DS_Store to Swift, ObjC & Xcode gitignores #4669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

ChrisMash
Copy link

Reasons for making this change

I've spent years manually adding .DS_Store to every .gitignore I've created from Swift.gitignore so those (seemingly) meaningless files don't get included, maybe I'm missing a reason that they've been left in, though they're excluded from the Global/macOS.gitignore, so assume they should also be excluded in these templates?

I assume it's ok to "ignore" the contribution guideline regarding only one template change per PR, seeing as the templates being changed say to also change the other ones? If not I can raise them separately, but it seems relevant to keep them all in one PR for a single change to each like this.

Links to documentation supporting these rule changes

Hope this suffices, let me know if not!

Screenshot 2025-06-15 at 16 18 56

Merge and Approval Steps

  • Confirm that you've read the contribution guidelines and ensured your PR aligns
  • Ensure CI is passing
  • Get a review and Approval from one of the maintainers

@ChrisMash ChrisMash requested a review from a team as a code owner June 15, 2025 15:20
@ChrisMash
Copy link
Author

Not sure how CI gets run, it doesn't seem to be happening automatically and I can't find anywhere that says how to trigger it or see any actions that obviously relate to it 👀

@wirecat
Copy link
Collaborator

wirecat commented Jun 20, 2025

We don't currently accept OS specific rules in our templates. We encourage people to instead use global gitignore configs and have a collection of them that can be used. Please see our Global/README for more information and Global/macOS.gitignore for an example.

@wirecat wirecat closed this Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants