Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For variables without a value, the requires checks do not fail.
In the following taskfile, each variable evaluates to "" (a nil value), and still the required checks pass.
This PR introduces a check for "nil" values which corrects this behavior.
Additional notes:
In
RunTask
the call sequence is very sensitive.areTaskRequiredVarsSet
depends on dynamic variables being resolved, which happens inCompiledTask
(a later call), howevershouldRunOnCurrentPlatform
(an earlier call) must occur before dynamic variables are expanded.The check for
areTaskRequiredVarsSet
occurs between those two calls (FastCompiledTask
andCompiledTask
). Therefore it does not have access to resolved dynamic variables. Moving calls around causes tests to fail, indicating intricate dependencies.Solution was to add a call
FastCompiledTaskWithVars
to the sequence which resolves the dynamic vars. Those dynamic vars should be cached, based on my code analysis, and therefore I don't expect any noticeable performance hit.fixes #2243