Skip to content

Commit df7737e

Browse files
authored
errgroup: remove redundant len check (#2354)
`len(g.children) > 0` is redundant because `range` already skips empty slice. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
1 parent 4e90cd4 commit df7737e

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

core/errgroup/errgroup.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -330,11 +330,9 @@ func isNotNil(err error) bool {
330330
return true
331331
}
332332

333-
if len(g.children) > 0 {
334-
for _, child := range g.children {
335-
if isNotNil(child) {
336-
return true
337-
}
333+
for _, child := range g.children {
334+
if isNotNil(child) {
335+
return true
338336
}
339337
}
340338

0 commit comments

Comments
 (0)