-
Notifications
You must be signed in to change notification settings - Fork 313
Add annotations for enabling logging for L4 ILB/NetLB #2864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi @anyush. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/lint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TortillaZHawaii: 2 warnings.
In response to this:
/lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
e1ac15c
to
e907e55
Compare
228e301
to
ccf92c7
Compare
/test pull-ingress-gce-verify |
ccf92c7
to
f4636c5
Compare
/approve /assign @mmamczur |
f4636c5
to
d849541
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: anyush, TortillaZHawaii The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d849541
to
307e871
Compare
307e871
to
f671e9b
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Allow to enable logging for L4 ILB/NetLB backends and provide sample rate for logging using service's annotations.