Skip to content

Add annotations for enabling logging for L4 ILB/NetLB #2864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anyush
Copy link
Contributor

@anyush anyush commented May 6, 2025

Allow to enable logging for L4 ILB/NetLB backends and provide sample rate for logging using service's annotations.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @anyush. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 6, 2025
@TortillaZHawaii
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2025
@TortillaZHawaii
Copy link
Member

/lint

Copy link
Contributor

@k8s-ci-robot k8s-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TortillaZHawaii: 2 warnings.

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@anyush anyush force-pushed the 4lb-enable-logging branch from d2e8d5b to eb28fcc Compare May 6, 2025 12:45
@anyush anyush force-pushed the 4lb-enable-logging branch 4 times, most recently from e1ac15c to e907e55 Compare May 8, 2025 11:38
@anyush anyush force-pushed the 4lb-enable-logging branch 2 times, most recently from 228e301 to ccf92c7 Compare May 12, 2025 12:58
@anyush
Copy link
Contributor Author

anyush commented May 12, 2025

/test pull-ingress-gce-verify

@anyush anyush force-pushed the 4lb-enable-logging branch from ccf92c7 to f4636c5 Compare May 13, 2025 10:54
@TortillaZHawaii
Copy link
Member

/approve

/assign @mmamczur

@anyush anyush force-pushed the 4lb-enable-logging branch from f4636c5 to d849541 Compare May 13, 2025 12:07
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anyush, TortillaZHawaii
Once this PR has been reviewed and has the lgtm label, please ask for approval from mmamczur. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anyush anyush force-pushed the 4lb-enable-logging branch from d849541 to 307e871 Compare May 15, 2025 14:31
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2025
@anyush anyush force-pushed the 4lb-enable-logging branch from 307e871 to f671e9b Compare May 19, 2025 14:03
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 19, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants