Skip to content

docs: update mDNS reload instructions on Mac #20955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ipochi
Copy link
Contributor

@ipochi ipochi commented Jun 18, 2025

The issue mentioned in #19367 is valid and not sure why its corresponding PR #19368 was closed.

I encountered the same while trying to setup ingress and ingress-dns on Mac. Add doc change to reflect that for newer versions, it might be better to run the alternative commands.

fixes: #19367

Signed-off-by: Imran Pochi <imranpochi@microsoft.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 18, 2025
@k8s-ci-robot k8s-ci-robot requested review from prezha and spowelljr June 18, 2025 22:34
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 18, 2025
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@ipochi ipochi changed the title docs: update mDNS reload instructions docs: update mDNS reload instructions on Mac Jun 18, 2025
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@medyagh
Copy link
Member

medyagh commented Jun 25, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2025
@medyagh medyagh merged commit 12752de into kubernetes:master Jun 25, 2025
6 of 7 checks passed
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ipochi, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update macOS mDNS commands for ingress-dns
4 participants