Skip to content

[ja] Sync /ja/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm.md with English version #51204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Aug 9, 2025
Merged

[ja] Sync /ja/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm.md with English version #51204

merged 16 commits into from
Aug 9, 2025
+241 −195

Conversation

y-sera
Copy link
Contributor

@y-sera y-sera commented Jun 8, 2025

Description

Updated /ja/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm.md to match the English version

Issue

Closes: #51203

/language ja
/assign

@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/localization General issues or PRs related to localization labels Jun 8, 2025
@k8s-ci-robot k8s-ci-robot requested review from inductor and kakts June 8, 2025 14:22
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 8, 2025
@netlify Netlify
Copy link

netlify bot commented Jun 8, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e6947ce
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6896241d37133b0008d89610
😎 Deploy Preview https://deploy-preview-51204--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Okabe-Junya
Okabe-Junya requested changes Jun 10, 2025
View reviewed changes
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちらもありがとうございます、同様にスタイルガイドへの準拠とcommitのsquashをお願いします

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 10, 2025
@Okabe-Junya
Copy link
Member

/unassign y-sera

kubernete org固有の仕組みやルールが多くて恐縮ですが、Kubernetes orgではPRのassigneeは approver を割り当てるために使用するので、ご自身を設定していただかなくて大丈夫です

@y-sera y-sera force-pushed the update-ja-docs-create-cluster-kubeadm.md branch from e462278 to 5fa0f7a Compare June 11, 2025 16:56
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 11, 2025
@y-sera y-sera force-pushed the update-ja-docs-create-cluster-kubeadm.md branch from 5fa0f7a to 38950fd Compare June 11, 2025 17:05
@y-sera
Copy link
Contributor Author

y-sera commented Jun 11, 2025

ありがとうございます。
こちらも一旦修正完了しました。
よろしくお願いいたします。

ebiiim
ebiiim reviewed Jun 17, 2025
View reviewed changes
Copy link
Contributor

@ebiiim ebiiim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

少し書き換えてみましたがどうでしょうか？

@kakts
Copy link
Member

kakts commented Jun 23, 2025

ありがとうございます！ /lgtm

@t-inu
Copy link
Member

t-inu commented Jul 17, 2025

/assign

t-inu
t-inu reviewed Jul 22, 2025
View reviewed changes
@t-inu
Copy link
Member

t-inu commented Jul 22, 2025

元の翻訳文の見直しもしたため、コメントが非常に多くなりました。
直接コメントができない行については、こちらに書きます。

  • 27行目

    website/content/ja/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm.md

    Line 27 in 3d916db

    - マシンごとに2GiB以上のRAMが搭載されていること。それ以下の場合、アプリ実行用のメモリーがほとんど残りません。

    メモリー -> メモリ

  • 262行目

    website/content/ja/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm.md

    Line 262 in 3d916db

    Podネットワークアドオンをインストールするには、コントロールプレーンノード上またはkubeconfigクレデンシャルを持っているノード上で、次のコマンドを実行します。

    この直前に、原文では以下があります。

    Please refer to the [Installing Addons](/docs/concepts/cluster-administration/addons/#networking-and-network-policy) page for a non-exhaustive list of networking addons supported by Kubernetes.

    そのため、次の翻訳文を入れていただきたいです。

    Kubernetesでサポートされているネットワークアドオンの非網羅的な一覧については、[アドオンのインストール](/docs/concepts/cluster-administration/addons/#networking-and-network-policy)のページを参照してください。

@Okabe-Junya
Copy link
Member

friendly ping @y-sera

ご確認お願いします

@y-sera y-sera force-pushed the update-ja-docs-create-cluster-kubeadm.md branch from 3d916db to ead2854 Compare August 3, 2025 16:34
@y-sera
Copy link
Contributor Author

y-sera commented Aug 3, 2025

修正遅くなり失礼いたしました。
コード自体の修正はひとまず実施しました。

元の翻訳文については以下コミットにて修正しました。
ead2854

今回の修正箇所に対する指摘修正は以下の1つのコミットにまとめてしまったのですが、問題ないでしょうか?
(量が多いので、いくつかに分割したほうがレビューしやすいでしょうか?)
c2becab

@y-sera y-sera force-pushed the update-ja-docs-create-cluster-kubeadm.md branch from 78a2712 to c689985 Compare August 3, 2025 17:03
@t-inu
Copy link
Member

t-inu commented Aug 4, 2025

コミットに関して、現在の状態で大丈夫です。
修正確認をしていきます。

t-inu
t-inu reviewed Aug 4, 2025
View reviewed changes
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正漏れかなと思われるところがありましたので、再度コメントしました。

y-sera and others added 7 commits August 9, 2025 01:18
@y-sera @t-inu
Update content/ja/docs/setup/production-environment/tools/kubeadm/cre…
62c0820 
…ate-cluster-kubeadm.md


modify with suggestion

Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
@y-sera @t-inu
Update content/ja/docs/setup/production-environment/tools/kubeadm/cre…
81a5c33 
…ate-cluster-kubeadm.md


modify with suggestion

Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
@y-sera @t-inu
Update content/ja/docs/setup/production-environment/tools/kubeadm/cre…
f6ae6d6 
…ate-cluster-kubeadm.md

Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
@y-sera @t-inu
Update content/ja/docs/setup/production-environment/tools/kubeadm/cre…
223c877 
…ate-cluster-kubeadm.md


modify with suggestion

Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
@y-sera @t-inu
Update content/ja/docs/setup/production-environment/tools/kubeadm/cre…
a260648 
…ate-cluster-kubeadm.md


modify with suggestsion

Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
@y-sera @t-inu
Update content/ja/docs/setup/production-environment/tools/kubeadm/cre…
f941c40 
…ate-cluster-kubeadm.md


modify with suggestion

Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
@y-sera @t-inu
Update content/ja/docs/setup/production-environment/tools/kubeadm/cre…
e6947ce 
…ate-cluster-kubeadm.md


modify with suggestion

Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com>
@y-sera
Copy link
Contributor Author

y-sera commented Aug 8, 2025

再レビューありがとうございます！
ご指摘いただいた箇所について修正いたしました。
お手数ですが再度確認をよろしくお願いいたします！

suggesstionから直接コミットする機能を使用したため、今度こそ修正漏れはないかと思います。
(この機能は今回初めて知りました)

t-inu
t-inu reviewed Aug 9, 2025
View reviewed changes
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認しました。問題ないと思います。
長期間になりましたが、対応ありがとうございました。
/approve

#51204 (comment)

ありがとうございます！ /lgtm

こちらは改行がなくて/lgtmが実行されていないため、改めて付与します。
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4580eaec0e965900eee8d187be6d13958dc739aa

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: t-inu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit 398cc2b into kubernetes:main Aug 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakts kakts

@ebiiim ebiiim

@t-inu t-inu

@Okabe-Junya Okabe-Junya

@inductor inductor

Assignees

@t-inu t-inu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ja] Sync /ja/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm.md with English version
6 participants
@y-sera @Okabe-Junya @kakts @t-inu @k8s-ci-robot @ebiiim