Added the suggestions for using comments with examples #636
Conversation
…er5io#550) Signed-off-by: avanshh99 <avanshetty196@gmail.com>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: avanshh99 <avanshetty196@gmail.com>
Signed-off-by: avanshh99 <avanshetty196@gmail.com>
avanshh99
force-pushed
the
feature/avan/550
branch
from
fd3618c to
899bd79
Compare
|
This is a good item to add to the weekly Websites meeting agenda. You can add this item in the doc, attend, and present it. Meeting details at https://meet.layer5.io. |
There was a problem hiding this comment.
Hi @avanshh99, great work!👍
Just one minor adjustment needed; the rest of the images are clear and the content is correct.
|
|
||
| {{< alert type="info" title="Missed Notifcations">}} | ||
| Kanvas does not track the read or unread status of messages inside comment threads for each user. If a user is mentioned, but misses the notification, they might not become aware of the comment until they receive a new notification for another comment in that conversation. | ||
| {{< /alert >}} | ||
|
|
||
| ## Best Practices for Effective Design Reviews | ||
|
|
||
| ### Using Comment Features Effectively |
There was a problem hiding this comment.
Since there's only one third-level heading under a second-level one, and then all fourth-level headings follow, we could simplify. Just remove that lone third-level heading and promote all the fourth-level headings to third-level ones.
There was a problem hiding this comment.
Oh got it will do it the changes and lyk 👍🏻
There was a problem hiding this comment.
@zihanKuang made the changes as mentioned!!
Signed-off-by: Zihan Kuang <127078886+zihanKuang@users.noreply.github.com>
Signed-off-by: avanshh99 <avanshetty196@gmail.com>
Signed-off-by: avanshh99 <avanshetty196@gmail.com>
Notes for Reviewers
This PR fixes #550
I have added the required examples as well as the details regarding the comments with proper visualization for the users