Open
Description
Current Behavior
Currently in the go code of nighthawks main.go we are using log.Fatal()
but log.Fatal()
terminates the program completely after encountering an error
Desired Behavior
Here in the go program I think we can handle errors more efficiently using log.Error()
instead of log.Fatal()
. As log.Fatal()
terminates the program completely but log.Error()
logs the error msg but allows the program to continue execution. This way, even if one error occurs, the program can continue to process the rest of the results, and the error messages will help in troubleshooting.
Alternatives / Additional Context
Contributor Resources
- See the Contributing to getnighthawk.dev Website
- See the Project Site section of GetNighthawk project doc
Activity
welcome commentedon Apr 11, 2023
Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
AryanSharma9917 commentedon Jun 19, 2023
HI @ShivangShandilya are you working on this issue?
ShivangShandilya commentedon Jun 19, 2023
hey @AryanSharma9917 as you can see I have already opened up a PR which might close this issue when merged