Skip to content

Changes in main.go #288

Open
Open
@ShivangShandilya

Description

@ShivangShandilya

Current Behavior

Currently in the go code of nighthawks main.go we are using log.Fatal() but log.Fatal() terminates the program completely after encountering an error

Desired Behavior

Here in the go program I think we can handle errors more efficiently using log.Error() instead of log.Fatal(). As log.Fatal() terminates the program completely but log.Error() logs the error msg but allows the program to continue execution. This way, even if one error occurs, the program can continue to process the rest of the results, and the error messages will help in troubleshooting.


Resources
image

Alternatives / Additional Context


Contributor Resources

Activity

welcome

welcome commented on Apr 11, 2023

@welcome

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.

linked a pull request that will close this issue on Apr 11, 2023
AryanSharma9917

AryanSharma9917 commented on Jun 19, 2023

@AryanSharma9917
Contributor

HI @ShivangShandilya are you working on this issue?

ShivangShandilya

ShivangShandilya commented on Jun 19, 2023

@ShivangShandilya
Author

hey @AryanSharma9917 as you can see I have already opened up a PR which might close this issue when merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @AryanSharma9917@ShivangShandilya

      Issue actions

        Changes in main.go · Issue #288 · layer5io/getnighthawk