-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fixed button to scroll back to original expanded position #6421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…behavior Signed-off-by: Rhoda Eboreime <rhodaivioje@gmail.com>
…behavior Signed-off-by: Rhoda Eboreime <rhodaivioje@gmail.com>
🚀 Preview for commit 6e0f311 at: https://68142a7d721d8695e56b885c--layer5.netlify.app |
Thanks, @ivioje! @sudhanshutech, will you be reviewing this one? |
@ivioje Everything is working good. 16-fix.mp4No need to do any commits until the core team member review this PR. |
Thanks! Yes, something can be done. I can try using |
Screencast.from.2025-05-04.13-10-17.webm@ivioje, there's an issue while trying to open multiple cards after row 2 |
@M-DEV-1 yes, that's what @Jeffrin2005 observed too. Do I have a go ahead to fix it? |
Yes, go for it @ivioje, thanks!! |
Also, I couldn’t seem to replicate this issue on mobile when I tested, but maybe you could also give it a try on your side to double-check. |
It works fine on mobile. |
Signed-off-by: Rhoda Eboreime <rhodaivioje@gmail.com>
Done! I've updated the pull request. Thanks! |
|
🚀 Preview for commit 9e090fb at: https://68187cb23e44f3c7fdb12194--layer5.netlify.app |
@ivioje Add it as an agenda item to the meeting minutes, if you would :) |
🚀 Preview for commit a0b8ab4 at: https://681893ab7d36f745ee489b38--layer5.netlify.app |
🚀 Preview for commit 80b4878 at: https://6818a15a7c748655ee862edd--layer5.netlify.app |
Hello @vishalvivekm! I'm just curious, is there a pending task on my end that makes this PR still open? |
@Jeffrin2005], perhaps, you can help tie this off.... |
@ivioje lgtm, but a minor issue that i figured out is , when we are expanding the multiple cards but by maintaing the first card without closing it, as you can see, we are going downward to expand the second item, tes1.mp4cc : @vishalvivekm @vr-varad |
Hello @Jeffrin2005. I don't see any issue in this. Perhaps you could explain clearly? The downward movement is so because the previously opened card closes when the current card is opened. As you can see from the screencast you sent, the previous card has a longer height with more content. Therefore, when it closes, the current card scrolls into the view. the downward movement is because of the height of the previous workshop card. If you expand a card above, it won't have the same behaviour. Also, if you expand a card with a smaller height the downward movement won't be visible. This works fine to me. |
@ivioje Oh, got it! My bad : ) Everything else looks good to me. |
@Jeffrin2005 is this is issue all good to go?? |
@vr-varad yeah. Everything is good. |
Description
This PR fixes #6417
Notes for Reviewers
Fixed button to scroll back to original expanded position
Signed commits