Enhanced modal guidance documentation while maintaining consistency #6386
Conversation
|
🚀 Preview for commit f884b6c at: https://67fb66ccbdfde4787534c7b0--layer5.netlify.app |
Signed-off-by: Souradip Pal <souradip1000@gmail.com>
Signed-off-by: Souradip Pal <souradip1000@gmail.com>
Souradip121
force-pushed
the
clean-modal-fix
branch
from
f884b6c to
f057d75
Compare
|
🚀 Preview for commit f057d75 at: https://67fb6c6e97bede7b5df62f25--layer5.netlify.app |
|
@vishalvivekm kindly look into the PR |
|
@Souradip121 Like discussed in previous meeting, reduce the image size, in overview section: |
|
In the code section, Confirmation Modal has following: The Confirmation Modal, we currently have:
|
|
Maybe we’d be better off moving the props details to the guidance section, and just adding a note in the code section pointing to it.
|
|
🚀 Preview for commit 3d2e5f0 at: https://67fcc996484bb4ba9bb445bc--layer5.netlify.app |
|
🚀 Preview for commit cefea03 at: https://67fd09c2d6a839683d6182f4--layer5.netlify.app |
Signed-off-by: Souradip Pal <souradip1000@gmail.com>
|
🚀 Preview for commit 1f43d19 at: https://680535e297fe4783b18d6781--layer5.netlify.app |
|
🚀 Preview for commit 583dc2d at: https://680626aac113236c196198e6--layer5.netlify.app |
| @@ -628,6 +650,16 @@ const SistentWrapper = styled.div` | |||
| padding-top: 1rem; | |||
| } | |||
|
|
|||
| /* Guidance list styling */ | |||
There was a problem hiding this comment.
please ensure its not effecting other guidance styles but being used consistently
|
@vishalvivekm @amitamrutiya lgtm, just i asked @Souradip121 the external styles added is not effecting else where but being used consistently |
Description
This PR fixes #6292
Notes for Reviewers
I have put consistent styling along with implementing guidance section and elaborating on the code section with basic imports
2025-04-02.12-32-50.mp4
Signed commits