Skip to content

Fix : Social Media Share Links are Not working #6409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Jeffrin2005
Copy link
Contributor

@Jeffrin2005 Jeffrin2005 commented Apr 26, 2025

Description

Merge Checklist

  • Prep screenshot or demo video for changelog entry, and attach it to issue.
fix91.mp4
  • Request for Peer Reviews
  • Completion of QA in Mobile Devices
  • Completion of QA in Desktop Devices

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Apr 26, 2025

🚀 Preview for commit 9f6d8e0 at: https://680c8b075319cfa12ef29d79--layer5.netlify.app

Copy link

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

1 similar comment
Copy link

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

Copy link
Contributor

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing these ShareButton with plain anchor tags, pointing to direct platform url, doesn't seem ideal @Jeffrin2005

We'd want to pre-fill the social media posts with link and via @<our-handles wherever possible.
See https://www.cncf.io/blog/ for inspiration

@vishalvivekm
Copy link
Contributor

@Jeffrin2005 Please sign off the commits
Let's also discuss this during the website call today at 5:30 PM IST

Added as an agenda item to the meeting minutes

@l5io
Copy link
Contributor

l5io commented Apr 28, 2025

🚀 Preview for commit e80cc9a at: https://680f5546dd51fd7cb89563bc--layer5.netlify.app

Signed-off-by: Jeffrin Jojo <jeffrinjojo1@gmail.com>
@l5io
Copy link
Contributor

l5io commented Apr 30, 2025

🚀 Preview for commit 0cfda54 at: https://6811d0c5b800200e687526c8--layer5.netlify.app

Signed-off-by: Jeffrin Jojo <jeffrinjojo1@gmail.com>
@l5io
Copy link
Contributor

l5io commented Apr 30, 2025

🚀 Preview for commit d3aa29f at: https://6811d59d995b8d1e3d94da27--layer5.netlify.app

Copy link

github-actions bot commented May 5, 2025

@l5io
Copy link
Contributor

l5io commented May 5, 2025

🚀 Preview for commit 9ace942 at: https://681897303e44f3134cb1202d--layer5.netlify.app

@vishalvivekm
Copy link
Contributor

@Jeffrin2005 Let's discuss this today in sites call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Social Media Share Links are Not working
3 participants