-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix: added special links to the mobile nav #6415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: added special links to the mobile nav #6415
Conversation
Signed-off-by: rohansen856 <rohansen856@gmail.com>
🚀 Preview for commit 7865a6e at: https://681146c999a34746ec8b50b7--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your job!
Thanks! Happy to contribute @vladboisa ! |
Thank you for your contribution! Add it as an agenda item to the meeting minutes, if you would :) |
|
🚀 Preview for commit f2d1364 at: https://6818b428612d93a37c311375--layer5.netlify.app |
Signed-off-by: rohansen856 <rohansen856@gmail.com>
🚀 Preview for commit e1e0241 at: https://6824a2e765e3b22609d7e5da--layer5.netlify.app |
@vishalvivekm As discussed in the previous meet, I have removed the duplicate Just removed the |
Description
This PR fixes #5813
Notes for Reviewers
As mentioned in the issue comment here, I have added all the special links that were present in the desktop navbar but previously not shown in mobile nav. Attaching screenshots fro reference:
Special links in desktop view:

Special links in mobile navbar after the changes:

One thing to note is that I refrained from impplementinng the
hover effect
that is in the desktop links as mobile view would not need the hover effects. Rest of the features are as is from the desktop view.This PR is ready for review. Please let me know if there is any need for changes. Thanks.
CC: @amitamrutiya @vishalvivekm
Signed commits