Skip to content

fix: added special links to the mobile nav #6415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rohansen856
Copy link
Contributor

Description

This PR fixes #5813

Notes for Reviewers
As mentioned in the issue comment here, I have added all the special links that were present in the desktop navbar but previously not shown in mobile nav. Attaching screenshots fro reference:

  • Special links in desktop view:
    image

  • Special links in mobile navbar after the changes:
    Screenshot from 2025-04-30 02-40-59

  • One thing to note is that I refrained from impplementinng the hover effect that is in the desktop links as mobile view would not need the hover effects. Rest of the features are as is from the desktop view.

This PR is ready for review. Please let me know if there is any need for changes. Thanks.

CC: @amitamrutiya @vishalvivekm

Signed commits

  • Yes, I signed my commits.

Signed-off-by: rohansen856 <rohansen856@gmail.com>
@l5io
Copy link
Contributor

l5io commented Apr 29, 2025

🚀 Preview for commit 7865a6e at: https://681146c999a34746ec8b50b7--layer5.netlify.app

Copy link
Contributor

@vladboisa vladboisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your job!

@rohansen856
Copy link
Contributor Author

Thanks! Happy to contribute @vladboisa !

@vishalvivekm
Copy link
Contributor

@rohansen856

Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

Copy link

github-actions bot commented May 5, 2025

@l5io
Copy link
Contributor

l5io commented May 5, 2025

🚀 Preview for commit f2d1364 at: https://6818b428612d93a37c311375--layer5.netlify.app

Signed-off-by: rohansen856 <rohansen856@gmail.com>
@l5io
Copy link
Contributor

l5io commented May 14, 2025

🚀 Preview for commit e1e0241 at: https://6824a2e765e3b22609d7e5da--layer5.netlify.app

@rohansen856
Copy link
Contributor Author

rohansen856 commented May 14, 2025

@vishalvivekm As discussed in the previous meet, I have removed the duplicate pricing menu item from the mobile nav so that the mobile nav does not get too long and cause accessibility issue for users.
Screenshot:
image

Just removed the pricing menu item from the solutions section and kept it in Products section. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Some navbar items are missing in moblie screen
4 participants