Skip to content

Fix: Rename Service Mesh Workshops to Cloud Native Workshops #6426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

Fix: Rename Service Mesh Workshops to Cloud Native Workshops #6426

wants to merge 12 commits into from

Conversation

M-DEV-1
Copy link
Member

@M-DEV-1 M-DEV-1 commented May 4, 2025

Description

I have renamed all references and links service-mesh-workshops links to cloud-native-workshops. I have also renamed the service-mesh-workshops folder in src/collections and modified the existing redirects.

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

M-DEV-1 added 4 commits May 4, 2025 17:09
@M-DEV-1
fix: rename Service Mesh Workshops to Cloud Native workshops
2c7e691 
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@M-DEV-1
change: all service mesh links to cloud native links
51c68c4 
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@M-DEV-1
change remaining links + setup redirects to new link
e079938 
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@M-DEV-1
rename service-mesh-workshops folder to cloud-native-workshops folder
f7471bc 
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@M-DEV-1
Copy link
Member Author

M-DEV-1 commented May 4, 2025

Screencast.from.2025-05-04.17-31-53.webm

@M-DEV-1
rename: Learn Service Mesh page title to Learn Cloud Native
d2b8dda 
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@l5io
Copy link
Contributor

l5io commented May 4, 2025

🚀 Preview for commit f7471bc at: https://68175aa02a427467c048ed73--layer5.netlify.app

M-DEV-1
M-DEV-1 commented May 4, 2025
View reviewed changes
src/pages/learn/index.js
@@ -13,7 +13,7 @@ const LearnGridPage = () => {
};
export default LearnGridPage;
export const Head = () => {
return <SEO title="Learn Service Mesh"
return <SEO title="Learn Cloud Native"
description="Learn Service Meshes: Istio, Linkerd, Envoy, Consul, Open Service Mesh, Traefik Mesh, Kuma, AWS App Mesh, Citrix, VMware Tanzu Service Mesh"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the new SEO description should be, any suggestions with this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works @M-DEV-1

@l5io
Copy link
Contributor

l5io commented May 4, 2025

🚀 Preview for commit d2b8dda at: https://68176068c53ca825a035fc14--layer5.netlify.app

@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2025 •
edited
Loading

View in catalog, Edit in playground or learn how to interpret Meshery Designs

@l5io
Copy link
Contributor

l5io commented May 5, 2025

🚀 Preview for commit 497a26d at: https://6818740a96ae6d11991a8d4b--layer5.netlify.app

@vishalvivekm
Copy link
Contributor

@M-DEV-1
Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST

Add it as an agenda item to the meeting minutes, if you would :)

@l5io
Copy link
Contributor

l5io commented May 5, 2025

🚀 Preview for commit 430d44a at: https://68189e283308705b2fc4e663--layer5.netlify.app

@vishalvivekm vishalvivekm mentioned this pull request May 5, 2025
Merged
vishalvivekm
vishalvivekm requested changes May 12, 2025
View reviewed changes
Copy link
Contributor

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of points discussed in previous meeting needs to be accounted for,

@l5io
Copy link
Contributor

l5io commented May 12, 2025

🚀 Preview for commit e8ec2bb at: https://6821e6e105c4fd1a39675e9c--layer5.netlify.app

@leecalcote
Copy link
Member

@M-DEV-1 fixed?

@M-DEV-1
Copy link
Member Author

M-DEV-1 commented May 15, 2025

@leecalcote yes, all done 👍

@leecalcote
Copy link
Member

@M-DEV-1, then, describe what you've changed, how you've incorporated feedback, take screenshots or video if necessary, and ask for a re-review out of the kindness of @vishalvivekm's heart.

@vishalvivekm
Copy link
Contributor

@leecalcote yes, all done 👍

@M-DEV-1, in the meeting, it was discussed that this change will result in all reference to individual workshop pages to be 404.
for example: /learn/service-mesh-workshops/istiocon-using-istio, results in 404 on your deploy preivew, how's that being accounted for here? Watch the recording if you would please.

M-DEV-1 and others added 2 commits May 26, 2025 17:42
@M-DEV-1
add splat redirect for links
780b68f 
Signed-off-by: M-DEV-1 <mahadevankizhakkedathu@gmail.com>
@M-DEV-1
Merge branch 'master' into M-DEV-1/fix-workshops-page-link
70de2f7 
Signed-off-by: mahadevan <135952571+M-DEV-1@users.noreply.github.com>
@M-DEV-1
Copy link
Member Author

M-DEV-1 commented May 26, 2025

I've added splat redirects for all the old links while referring to this doc

@M-DEV-1 M-DEV-1 closed this May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalvivekm vishalvivekm

Assignees
No one assigned
Labels
area/handbook area/site-config
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@M-DEV-1 @l5io @vishalvivekm @leecalcote