Skip to content

fix: Unify version display for public and private designs #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zihanKuang
Copy link

Notes for Reviewers

This PR fixes: https://github.com/layer5io/meshery-cloud/issues/3585

Reason

There are three relevant states for a design: private, public, and published. The private and public states should both reflect the current draft's version number, which is stored in the version field. Only a published design should display the published_version.

The bug was that the UI was incorrectly displaying the published_version for designs that were set to public. This created problems:

  1. Inconsistent Versions: If a public design had no published_version, the UI would show an incorrect fallback value (like 0.0.0 or "").
  2. Wrong Versions: If a public design has a published_version, the UI would show an incorrect value.

Fix

20250617_200454.mp4

Signed-off-by: Zihan Kuang <zihan_kuang@outlook.com>
@zihanKuang zihanKuang requested a review from FaheemOnHub June 17, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant