Skip to content

Commit d1b498f

Browse files
CopilotLiliDeng
andauthored
Add private network configuration to azure.yml runbook (#3843)
* Initial plan for issue * Add private network configuration to azure.yml runbook Co-authored-by: LiliDeng <10083705+LiliDeng@users.noreply.github.com> * Fix use_public_address default value to true Co-authored-by: LiliDeng <10083705+LiliDeng@users.noreply.github.com> * Add create_public_address variable to azure.yml runbook Co-authored-by: LiliDeng <10083705+LiliDeng@users.noreply.github.com> * Add fallback to default values for empty subnet and vnet names Co-authored-by: LiliDeng <10083705+LiliDeng@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: LiliDeng <10083705+LiliDeng@users.noreply.github.com>
1 parent c8477fd commit d1b498f

File tree

2 files changed

+21
-2
lines changed

2 files changed

+21
-2
lines changed

lisa/sut_orchestrator/azure/platform_.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1153,8 +1153,12 @@ def _create_deployment_parameters(
11531153
arm_parameters.virtual_network_resource_group = (
11541154
self._azure_runbook.virtual_network_resource_group
11551155
)
1156-
arm_parameters.subnet_prefix = self._azure_runbook.subnet_prefix
1157-
arm_parameters.virtual_network_name = self._azure_runbook.virtual_network_name
1156+
arm_parameters.subnet_prefix = (
1157+
self._azure_runbook.subnet_prefix or AZURE_SUBNET_PREFIX
1158+
)
1159+
arm_parameters.virtual_network_name = (
1160+
self._azure_runbook.virtual_network_name or AZURE_VIRTUAL_NETWORK_NAME
1161+
)
11581162
arm_parameters.use_ipv6 = self._azure_runbook.use_ipv6
11591163

11601164
is_windows: bool = False

microsoft/runbook/azure.yml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,16 @@ variable:
3939
value: "default"
4040
- name: use_ipv6
4141
value: false
42+
- name: vnet_resource_group
43+
value: ""
44+
- name: vnet_name
45+
value: ""
46+
- name: subnet_name
47+
value: ""
48+
- name: use_public_address
49+
value: true
50+
- name: create_public_address
51+
value: true
4252
concurrency: $(concurrency)
4353
notifier:
4454
- type: html
@@ -58,6 +68,11 @@ platform:
5868
wait_delete: $(wait_delete)
5969
azcopy_path: $(azcopy_path)
6070
use_ipv6: $(use_ipv6)
71+
virtual_network_resource_group: $(vnet_resource_group)
72+
virtual_network_name: $(vnet_name)
73+
subnet_prefix: $(subnet_name)
74+
use_public_address: $(use_public_address)
75+
create_public_address: $(create_public_address)
6176
requirement:
6277
core_count:
6378
min: 2

0 commit comments

Comments
 (0)